Provide a Chrome-owned buffer to FFmpeg for video decoding, instead of

media/filters/ffmpeg_video_decoder.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_FILTERS_FFMPEG_VIDEO_DECODER_H_
 #define MEDIA_FILTERS_FFMPEG_VIDEO_DECODER_H_
 
 #include <deque>
 
 #include "base/callback.h"
@@ skipping 16 matching lines @@
   virtual void Initialize(const scoped_refptr<DemuxerStream>& stream,
                           const PipelineStatusCB& status_cb,
                           const StatisticsCB& statistics_cb) OVERRIDE;
   virtual void Read(const ReadCB& read_cb) OVERRIDE;
   virtual void Reset(const base::Closure& closure) OVERRIDE;
   virtual void Stop(const base::Closure& closure) OVERRIDE;
   virtual const gfx::Size& natural_size() OVERRIDE;
 
   AesDecryptor* decryptor();
 
+  // called from within ffmpeg

[Ami GONE FROM CHROMIUM, 2012/05/26 22:52:34]

Comments need to be complete English sentences, starting w/ capital, ending with
period. 
More importantly, this should document what the return value means, and what the
method does.
I suspect a pointer to the interface this satisfies is in order.

+  int GetVideoBuffer(AVFrame *frame);
+
  protected:
   virtual ~FFmpegVideoDecoder();
 
  private:
   enum DecoderState {
     kUninitialized,
     kNormal,
     kFlushCodec,
     kDecodeFinished,
   };
 
   // Carries out the reading operation scheduled by Read().
   void DoRead(const ReadCB& read_cb);
 
   // Reads from the demuxer stream with corresponding callback method.
   void ReadFromDemuxerStream();
   void DecodeBuffer(const scoped_refptr<Buffer>& buffer);
 
   // Carries out the decoding operation scheduled by DecodeBuffer().
   void DoDecodeBuffer(const scoped_refptr<Buffer>& buffer);
+  int AllocBuffer(VideoFrame **ptr);
   bool Decode(const scoped_refptr<Buffer>& buffer,
               scoped_refptr<VideoFrame>* video_frame);
 
   // Delivers the frame to |read_cb_| and resets the callback.
   void DeliverFrame(const scoped_refptr<VideoFrame>& video_frame);
 
   // Releases resources associated with |codec_context_| and |av_frame_|
   // and resets them to NULL.
   void ReleaseFFmpegResources();
 
@@ skipping 32 matching lines @@
   scoped_refptr<DemuxerStream> demuxer_stream_;
 
   AesDecryptor decryptor_;
 
   DISALLOW_COPY_AND_ASSIGN(FFmpegVideoDecoder);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_FILTERS_FFMPEG_VIDEO_DECODER_H_