Track buffered byte ranges correctly in media::Pipeline.

media/base/pipeline.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_PIPELINE_H_
 #define MEDIA_BASE_PIPELINE_H_
 
 #include <string>
 
 #include "base/gtest_prod_util.h"
@@ skipping 201 matching lines @@
 
   // Get approximate time ranges of buffered media.
   Ranges<base::TimeDelta> GetBufferedTimeRanges();
 
   // Get the duration of the media in microseconds.  If the duration has not
   // been determined yet, then returns 0.
   base::TimeDelta GetMediaDuration() const;
 
   // Get the total number of bytes that are buffered on the client and ready to
   // be played.
+  // TODO(fischman): this interface is only needed so WMPI can provide
+  // bytesLoaded() which is only present so that HTMLMediaElement can decide
+  // whether progress has been made.  Bogus!  http://webk.it/86113
   int64 GetBufferedBytes() const;
 
   // Get the total size of the media file.  If the size has not yet been
   // determined or can not be determined, this value is 0.
   int64 GetTotalBytes() const;
 
   // Gets the natural size of the video output in pixel units.  If there is no
   // video or the video has not been rendered yet, the width and height will
   // be 0.
   void GetNaturalVideoSize(gfx::Size* out_size) const;
@@ skipping 60 matching lines @@
 
   // Returns true if the given state is one that transitions to a new state
   // after iterating through each filter.
   static bool TransientState(State state);
 
   // Given the current state, returns the next state.
   State FindNextState(State current);
 
   // DataSourceHost (by way of DemuxerHost) implementation.
   virtual void SetTotalBytes(int64 total_bytes) OVERRIDE;
-  virtual void SetBufferedBytes(int64 buffered_bytes) OVERRIDE;
+  virtual void AddBufferedByteRange(int64 start, int64 end) OVERRIDE;
   virtual void SetNetworkActivity(bool is_downloading_data) OVERRIDE;
 
   // DemuxerHost implementaion.
   virtual void SetDuration(base::TimeDelta duration) OVERRIDE;
   virtual void SetCurrentReadPosition(int64 offset) OVERRIDE;
   virtual void OnDemuxerError(PipelineStatus error) OVERRIDE;
 
   // FilterHost implementation.
   virtual void SetError(PipelineStatus error) OVERRIDE;
   virtual base::TimeDelta GetTime() const OVERRIDE;
@@ skipping 103 matching lines @@
   // state first.
   // 2. when pipeline has been initialized, we will first transit to pausing
   // => flushing => stopping => stopped state.
   // This will remove the race condition during stop between filters.
   void TearDownPipeline();
 
   // Compute the current time. Assumes that the lock has been acquired by the
   // caller.
   base::TimeDelta GetCurrentTime_Locked() const;
 
-  // Update internal records of which time ranges are buffered.
-  void UpdateBufferedTimeRanges_Locked();
+  // Compute the time corresponding to a byte offset.
+  base::TimeDelta TimeForByteOffset_Locked(int64 byte_offset) const;
 
   // Initiates a Stop() on |demuxer_| & |pipeline_filter_|. |callback|
   // is called once both objects have been stopped.
   void DoStop(const base::Closure& callback);
 
   // Called when |demuxer_| has stopped. This method calls Stop()
   // on |pipeline_filter_|.
   void OnDemuxerStopDone(const base::Closure& callback);
 
   // Initiates a Seek() on the |demuxer_| & |pipeline_filter_|.
@@ skipping 31 matching lines @@
 
   // Whether or not the pipeline is perform a stop operation.
   bool tearing_down_;
 
   // Whether or not an error triggered the teardown.
   bool error_caused_teardown_;
 
   // Whether or not a playback rate change should be done once seeking is done.
   bool playback_rate_change_pending_;
 
   // Amount of available buffered data.  Set by filters.

[scherkus (not reviewing), 2012/05/29 18:13:29]

s/filters/data source/?

technically it's the demuxer because DemuxerHost extends DataSourceHost :s

[Ami GONE FROM CHROMIUM, 2012/05/29 20:45:44]

Just removed that part of the comment (pointers to {Demuxer,DataSource}Host
exist at the AddBufferedByteRange declaration above).

-  int64 buffered_bytes_;
+  Ranges<int64> buffered_byte_ranges_;
 
   // Approximate time ranges of buffered media.
   Ranges<base::TimeDelta> buffered_time_ranges_;
 
   // Total size of the media.  Set by filters.
   int64 total_bytes_;
 
   // Video's natural width and height.  Set by filters.
   gfx::Size natural_size_;
 
@@ skipping 89 matching lines @@
   // Time of pipeline creation; is non-zero only until the pipeline first
   // reaches "kStarted", at which point it is used & zeroed out.
   base::Time creation_time_;
 
   DISALLOW_COPY_AND_ASSIGN(Pipeline);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_PIPELINE_H_