Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10451047: content: Move javascript_message_type.h into content/ from ui/. (Closed)

Created:
8 years, 7 months ago by tfarina
Modified:
8 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

content: Move javascript_message_type.h into content/ from ui/. BUG=98716 R=jam@chromium.org TBR=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139242

Patch Set 1 : #

Total comments: 4

Patch Set 2 : move to common #

Total comments: 2

Patch Set 3 : rm CONTEXT_EXPORT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -91 lines) Patch
M chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_modal_dialogs/javascript_dialog_creator.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/javascript_app_modal_dialog_gtk.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/javascript_app_modal_dialog_views.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/render_view_host_manager_unittest.cc View 1 4 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/view_messages.h View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M content/content_common.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/javascript_dialogs.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
A content/public/common/javascript_message_type.h View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 8 chunks +8 lines, -9 lines 0 comments Download
M content/shell/shell_javascript_dialog.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/shell_javascript_dialog_creator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_javascript_dialog_creator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/shell_javascript_dialog_mac.mm View 1 chunk +3 lines, -5 lines 0 comments Download
M content/shell/shell_javascript_dialog_win.cc View 5 chunks +8 lines, -7 lines 0 comments Download
D ui/base/javascript_message_type.h View 1 chunk +0 lines, -21 lines 0 comments Download
M ui/ui.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
The patch I sent request through email. Please, take a look.
8 years, 7 months ago (2012-05-25 23:56:51 UTC) #1
jochen (gone - plz use gerrit)
http://codereview.chromium.org/10451047/diff/3001/content/common/view_messages.h File content/common/view_messages.h (right): http://codereview.chromium.org/10451047/diff/3001/content/common/view_messages.h#newcode76 content/common/view_messages.h:76: IPC_ENUM_TRAITS(content::JavaScriptMessageType) nit. alphabetical order http://codereview.chromium.org/10451047/diff/3001/content/public/browser/javascript_message_type.h File content/public/browser/javascript_message_type.h (right): http://codereview.chromium.org/10451047/diff/3001/content/public/browser/javascript_message_type.h#newcode5 ...
8 years, 7 months ago (2012-05-26 11:19:54 UTC) #2
tfarina
http://codereview.chromium.org/10451047/diff/3001/content/common/view_messages.h File content/common/view_messages.h (right): http://codereview.chromium.org/10451047/diff/3001/content/common/view_messages.h#newcode76 content/common/view_messages.h:76: IPC_ENUM_TRAITS(content::JavaScriptMessageType) On 2012/05/26 11:19:55, jochen wrote: > nit. alphabetical ...
8 years, 7 months ago (2012-05-26 12:33:32 UTC) #3
jochen (gone - plz use gerrit)
unofficial content lg On Sat, May 26, 2012 at 2:33 PM, <tfarina@chromium.org> wrote: > > ...
8 years, 7 months ago (2012-05-26 12:36:27 UTC) #4
jam
8 years, 6 months ago (2012-05-28 07:13:42 UTC) #5 
lgtm with nits

http://codereview.chromium.org/10451047/diff/5002/content/public/common/javas...
File content/public/common/javascript_message_type.h (right):

http://codereview.chromium.org/10451047/diff/5002/content/public/common/javas...
content/public/common/javascript_message_type.h:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
is this "svn mv"d? otherwise svn history is lost

http://codereview.chromium.org/10451047/diff/5002/content/public/common/javas...
content/public/common/javascript_message_type.h:13: enum CONTENT_EXPORT
JavaScriptMessageType {
you don't need CONTENT_EXPORT on enums

Powered by Google App Engine
This is Rietveld 408576698