Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 10451028: Add support for GCC_WARN_ABOUT_INVALID_OFFSETOF_MACRO to xcode emulation. (Closed)

Created:
8 years, 7 months ago by viettrungluu
Modified:
8 years, 7 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Add support for GCC_WARN_ABOUT_INVALID_OFFSETOF_MACRO to xcode emulation. Committed: https://code.google.com/p/gyp/source/detail?r=1395

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : argh #

Patch Set 4 : '' #

Patch Set 5 : license headers, pset #

Patch Set 6 : grrrr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -0 lines) Patch
M pylib/gyp/xcode_emulation.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A test/mac/gyptest-xcode-gcc.py View 1 2 3 4 1 chunk +39 lines, -0 lines 0 comments Download
A test/mac/xcode-gcc/test.gyp View 1 2 3 1 chunk +43 lines, -0 lines 0 comments Download
A test/mac/xcode-gcc/warn_about_invalid_offsetof_macro.cc View 1 2 3 4 5 1 chunk +15 lines, -0 lines 0 comments Download
A test/mac/xcode-gcc/warn_about_missing_newline.c View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
viettrungluu
8 years, 7 months ago (2012-05-25 00:21:13 UTC) #1
Nico
Can't you change your code to use __builtin_offsetof when __GNUC__ is set?
8 years, 7 months ago (2012-05-25 00:38:30 UTC) #2
viettrungluu
On 2012/05/25 00:38:30, Nico wrote: > Can't you change your code to use __builtin_offsetof when ...
8 years, 7 months ago (2012-05-25 16:16:54 UTC) #3
viettrungluu
On 2012/05/25 16:16:54, viettrungluu wrote: > On 2012/05/25 00:38:30, Nico wrote: > > Can't you ...
8 years, 7 months ago (2012-05-25 16:30:07 UTC) #4
Nico
On 2012/05/25 16:30:07, viettrungluu wrote: > On 2012/05/25 16:16:54, viettrungluu wrote: > > On 2012/05/25 ...
8 years, 7 months ago (2012-05-25 18:17:08 UTC) #5
viettrungluu
On 2012/05/25 18:17:08, Nico wrote: > On 2012/05/25 16:30:07, viettrungluu wrote: > > On 2012/05/25 ...
8 years, 7 months ago (2012-05-25 22:23:21 UTC) #6
Nico
8 years, 7 months ago (2012-05-25 22:27:56 UTC) #7
LGTM!

Powered by Google App Engine
This is Rietveld 408576698