Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Unified Diff: chrome/browser/resources/print_preview/cloud_print_interface.js

Issue 10450022: Print Preview Print Destination Search Widget (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Set --bary flag Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/cloud_print_interface.js
diff --git a/chrome/browser/resources/print_preview/cloud_print_interface.js b/chrome/browser/resources/print_preview/cloud_print_interface.js
index b7e7c7cf748e4922ed1c46a6c6bec2250775e9b6..15cc31df04e2788989f303c5174f320e93bbe17b 100644
--- a/chrome/browser/resources/print_preview/cloud_print_interface.js
+++ b/chrome/browser/resources/print_preview/cloud_print_interface.js
@@ -103,7 +103,7 @@ cr.define('cloudprint', function() {
* @param {!print_preview.Destination} destination Destination to print to.
* @param {!print_preview.PrintTicketStore} printTicketStore Used to create
* the state of the print ticket.
- * @return {object} Google Cloud Print print ticket.
+ * @return {!Object} Google Cloud Print print ticket.
*/
createPrintTicket: function(destination, printTicketStore) {
assert(!destination.isLocal,
@@ -247,14 +247,14 @@ cr.define('cloudprint', function() {
onSearchDone_: function(result) {
var printerListJson = result['printers'] || [];
var printerList = [];
- for (var printerJson, i = 0; printerJson = printerListJson[i]; i++) {
+ printerListJson.forEach(function(printerJson) {
try {
printerList.push(
cloudprint.CloudDestinationParser.parse(printerJson));
} catch (err) {
console.error('Unable to parse cloud print destination: ' + err);
}
- }
+ });
var isRecent = result['request']['params']['q'] == '^recent';
var searchDoneEvent =
new cr.Event(CloudPrintInterface.EventType.SEARCH_DONE);

Powered by Google App Engine
This is Rietveld 408576698