runtime/vm/heap.cc - Issue 10450014: Request for comments on overall approach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/heap.cc

Issue 10450014: Request for comments on overall approach. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: fix scavenger and freelist handling Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/heap.cc

diff --git a/runtime/vm/heap.cc b/runtime/vm/heap.cc

index 1a4df3c328eb4f54527af2524f8d398937bea608..dd87de49abe162f2c9fdaf8aeeaec3cd61b558e8 100644

--- a/runtime/vm/heap.cc

+++ b/runtime/vm/heap.cc

@@ -132,8 +132,9 @@ void Heap::IterateCodePointers(ObjectPointerVisitor* visitor) {

RawInstructions* Heap::FindObjectInCodeSpace(FindObjectVisitor* visitor) {

// The code heap can only have RawInstructions objects.

RawObject* raw_obj = code_space_->FindObject(visitor);

+ // TODO(vegorov): class lookup to a helper method.

ASSERT((raw_obj == Object::null()) ||

- (raw_obj->ptr()->class_->ptr()->instance_kind_ == kInstructions));

+ (raw_obj->GetClass()->ptr()->instance_kind_ == kInstructions));

return reinterpret_cast<RawInstructions*>(raw_obj);

}