runtime/vm/gc_marker.cc - Issue 10450014: Request for comments on overall approach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/gc_marker.cc

Issue 10450014: Request for comments on overall approach. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: fix scavenger and freelist handling Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/gc_marker.cc

diff --git a/runtime/vm/gc_marker.cc b/runtime/vm/gc_marker.cc

index 6bdb245a0672d7e4f45da57fa6a17472740dce69..c04163744917c9fe42b846885aee52bade372fd5 100644

--- a/runtime/vm/gc_marker.cc

+++ b/runtime/vm/gc_marker.cc

@@ -139,7 +139,8 @@ class MarkingVisitor : public ObjectPointerVisitor {

// Mark the object and push it on the marking stack.

ASSERT(!raw_obj->IsMarked());

- RawClass* raw_class = raw_obj->ptr()->class_;

+ // TODO(vegorov): consider moving it to a separate helper method.

+ RawClass* raw_class = raw_obj->GetClass();

Ivan Posva 2012/05/26 04:34:46 This does not need to be done early anymore as the

raw_obj->SetMarkBit();

marking_stack_->Push(raw_obj);