Request for comments on overall approach.

runtime/vm/raw_object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_RAW_OBJECT_H_
 #define VM_RAW_OBJECT_H_
 
 #include "platform/assert.h"
 #include "vm/globals.h"
 #include "vm/token.h"
@@ skipping 218 matching lines @@
 
   bool IsNewObject() const {
     uword addr = reinterpret_cast<uword>(this);
     return (addr & kNewObjectAlignmentOffset) == kNewObjectAlignmentOffset;
   }
   bool IsOldObject() const {
     uword addr = reinterpret_cast<uword>(this);
     return (addr & kNewObjectAlignmentOffset) == kOldObjectAlignmentOffset;
   }
 
+  bool IsFree() const {
+    return FreeBit::decode(ptr()->tags_);
+  }
+
   // Support for GC marking bit.
   bool IsMarked() const {
     return MarkBit::decode(ptr()->tags_);
   }
   void SetMarkBit() {
     ASSERT(!IsMarked());
     uword tags = ptr()->tags_;
     ptr()->tags_ = MarkBit::update(true, tags);
   }
   void ClearMarkBit() {
@@ skipping 56 matching lines @@
   static bool IsErrorClassIndex(intptr_t index);
   static bool IsNumberClassIndex(intptr_t index);
   static bool IsIntegerClassIndex(intptr_t index);
   static bool IsStringClassIndex(intptr_t index);
   static bool IsOneByteStringClassIndex(intptr_t index);
   static bool IsTwoByteStringClassIndex(intptr_t index);
   static bool IsExternalStringClassIndex(intptr_t index);
   static bool IsBuiltinListClassIndex(intptr_t index);
   static bool IsByteArrayClassIndex(intptr_t index);
 
+  RawClass* GetClass() const {
+    return GetClass(ptr()->tags_);

[Ivan Posva, 2012/05/26 04:34:46]

If anything then all we should have here is GetClassId().

[Vyacheslav Egorov (Google), 2012/05/26 16:48:22]

Will do.

+  }
+
+  static RawClass* GetClass(uword tags);

[Ivan Posva, 2012/05/26 04:34:46]

Does not belong here. Please move to Object, or ClassTable.

[Vyacheslav Egorov (Google), 2012/05/26 16:48:22]

Will do.

+
+  class CreatedFromSnapshotTag : public BitField<bool, kFromSnapshotBit, 1> {};
+
  protected:
-  RawClass* class_;
   uword tags_;  // Various object tags (bits).
 
  private:
   class FreeBit : public BitField<bool, kFreeBit, 1> {};
 
   class MarkBit : public BitField<bool, kMarkBit, 1> {};
 
   class CanonicalObjectTag : public BitField<bool, kCanonicalBit, 1> {};
 
-  class CreatedFromSnapshotTag : public BitField<bool, kFromSnapshotBit, 1> {};
 
   RawObject* ptr() const {
     ASSERT(IsHeapObject());
     return reinterpret_cast<RawObject*>(
         reinterpret_cast<uword>(this) - kHeapObjectTag);
   }
 
   intptr_t SizeFromClass() const;
 
   intptr_t GetClassIndex() const {
@@ skipping 57 matching lines @@
   intptr_t token_index_;
   int8_t class_state_;  // Of type ClassState.
   bool is_const_;
   bool is_interface_;
 
   friend class Object;
   friend class RawInstance;
   friend class RawInstructions;
   friend RawClass* AllocateFakeClass();
   friend class SnapshotReader;
+  friend class ClassTable;
 };
 
 
 class RawUnresolvedClass : public RawObject {
   RAW_HEAP_OBJECT_IMPLEMENTATION(UnresolvedClass);
 
   RawObject** from() {
     return reinterpret_cast<RawObject**>(&ptr()->library_prefix_);
   }
   RawLibraryPrefix* library_prefix_;  // Library prefix qualifier for the ident.
@@ skipping 1082 matching lines @@
          kExternalUint64Array == kByteArray + 18 &&
          kExternalFloat32Array == kByteArray + 19 &&
          kExternalFloat64Array == kByteArray + 20 &&
          kClosure == kByteArray + 21);
   return (index >= kByteArray && index <= kClosure);
 }
 
 }  // namespace dart
 
 #endif  // VM_RAW_OBJECT_H_