Request for comments on overall approach.

runtime/vm/intrinsifier_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // The intrinsic code below is executed before a method has built its frame.
 // The return address is on the stack and the arguments below it.
 // Registers EDX (arguments descriptor) and ECX (function) must be preserved.
 // Each intrinsification method returns true if the corresponding
 // Dart method was intrinsified.
 
@@ skipping 71 matching lines @@
     __ Bind(&size_tag_overflow);
     __ movl(EDI, Immediate(0));
     __ Bind(&done);
 
     // Get the class index and insert it into the tags.
     const Class& cls = Class::Handle(isolate->object_store()->array_class());
     __ orl(EDI, Immediate(RawObject::ClassTag::encode(cls.index())));
     __ movl(FieldAddress(EAX, Array::tags_offset()), EDI);  // Tags.
   }
 
-  // Store class value for array.
   // EAX: new object start as a tagged pointer.
   // EBX: new object end address.
-  __ movl(EDI, FieldAddress(CTX, Context::isolate_offset()));
-  __ movl(EDI, Address(EDI, Isolate::object_store_offset()));
-  __ movl(EDI, Address(EDI, ObjectStore::array_class_offset()));
-  __ StoreIntoObject(EAX, FieldAddress(EAX, Array::class_offset()), EDI);
-
   // Store the type argument field.
   __ movl(EDI, Address(ESP, kTypeArgumentsOffset));  // type argument.
   __ StoreIntoObject(EAX,
                      FieldAddress(EAX, Array::type_arguments_offset()),
                      EDI);
 
   // Set the length field.
   __ movl(EDI, Address(ESP, kArrayLengthOffset));  // Array Length.
   __ StoreIntoObject(EAX, FieldAddress(EAX, Array::length_offset()), EDI);
 
@@ skipping 87 matching lines @@
     __ cmpl(EDI, raw_null);
     __ j(EQUAL, &checked_ok, Assembler::kNearJump);
 
     __ movl(EBX, Address(ESP, + 3 * kWordSize));  // Array.
     __ movl(EBX, FieldAddress(EBX, type_args_field_offset));
     // EBX: Type arguments of array.
     __ cmpl(EBX, raw_null);
     __ j(EQUAL, &checked_ok, Assembler::kNearJump);
     // Check if it's Dynamic.
     // For now handle only TypeArguments and bail out if InstantiatedTypeArgs.
-    __ movl(EAX, FieldAddress(EBX, Object::class_offset()));
-    __ CompareObject(EAX, Object::ZoneHandle(Object::type_arguments_class()));
+    __ CompareClassOf(EBX, Class::Handle(Object::type_arguments_class()), EAX);
     __ j(NOT_EQUAL, &fall_through, Assembler::kNearJump);
     // Get type at index 0.
     __ movl(EAX, FieldAddress(EBX, TypeArguments::type_at_offset(0)));
     __ CompareObject(EAX, Type::ZoneHandle(Type::DynamicType()));
     __ j(EQUAL,  &checked_ok, Assembler::kNearJump);
     // Check for int and num.
     __ testl(EDI, Immediate(kSmiTagMask));  // Value is Smi?
     __ j(NOT_ZERO, &fall_through, Assembler::kNearJump);  // Non-smi value.
     __ CompareObject(EAX, Type::ZoneHandle(Type::IntInterface()));
     __ j(EQUAL,  &checked_ok, Assembler::kNearJump);
@@ skipping 78 matching lines @@
   tags = RawObject::ClassTag::update(cls.index(), tags);
   __ movl(FieldAddress(EAX, GrowableObjectArray::tags_offset()),
           Immediate(tags));
 
   // Store backing array object in growable array object.
   __ movl(EBX, Address(ESP, kArrayOffset));  // data argument.
   __ StoreIntoObject(EAX,
                      FieldAddress(EAX, GrowableObjectArray::data_offset()),
                      EBX);
 
-  // Store class value for the growable array object.
   // EAX: new growable array object start as a tagged pointer.
-  __ movl(EBX, FieldAddress(CTX, Context::isolate_offset()));
-  __ movl(EBX, Address(EBX, Isolate::object_store_offset()));
-  __ movl(EBX, Address(EBX, ObjectStore::growable_object_array_class_offset()));
-  __ StoreIntoObject(EAX,
-                     FieldAddress(EAX, GrowableObjectArray::class_offset()),
-                     EBX);
-
   // Store the type argument field in the growable array object.
   __ movl(EBX, Address(ESP, kTypeArgumentsOffset));  // type argument.
   __ StoreIntoObject(EAX,
                      FieldAddress(EAX,
                                   GrowableObjectArray::type_arguments_offset()),
                      EBX);
 
   // Set the length field in the growable array object to 0.
   __ movl(FieldAddress(EAX, GrowableObjectArray::length_offset()),
           Immediate(0));
@@ skipping 417 matching lines @@
   Label receiver_not_smi;
   __ Bind(&check_for_mint);
   __ movl(EAX, Address(ESP, + 2 * kWordSize));  // Receiver.
   __ testl(EAX, Immediate(kSmiTagMask));
   __ j(NOT_ZERO, &receiver_not_smi);
 
   // Note that an instance of Mint never contains a value that can be
   // represented by Smi.
   // Left is Smi, return false if right is Mint, otherwise fall through.
   __ movl(EAX, Address(ESP, + 1 * kWordSize));  // Right argument.
-  __ movl(EAX, FieldAddress(EAX, Object::class_offset()));
-  __ CompareObject(EAX, Class::ZoneHandle(object_store->mint_class()));
+  __ CompareClassOf(EAX, Class::Handle(object_store->mint_class()), EAX);
   __ j(NOT_EQUAL, &fall_through);
   __ LoadObject(EAX, bool_false);  // Smi == Mint -> false.
   __ ret();
 
   __ Bind(&receiver_not_smi);
   // EAX:: receiver.
-  __ movl(EAX, FieldAddress(EAX, Object::class_offset()));
-  __ CompareObject(EAX, Class::ZoneHandle(object_store->mint_class()));
+  __ CompareClassOf(EAX, Class::Handle(object_store->mint_class()), EAX);
   __ j(NOT_EQUAL, &fall_through);
   // Receiver is Mint, return false if right is Smi.
   __ movl(EAX, Address(ESP, + 1 * kWordSize));  // Right argument.
   __ testl(EAX, Immediate(kSmiTagMask));
   __ j(NOT_ZERO, &fall_through);
   __ LoadObject(EAX, bool_false);  // Smi == Mint -> false.
   __ ret();
   // TODO(srdjan): Implement Mint == Mint comparison.
 
   __ Bind(&fall_through);
@@ skipping 48 matching lines @@
 
 // Check if the last argument is a double, jump to label 'is_smi' if smi
 // (easy to convert to double), otherwise jump to label 'not_double_smi',
 // Returns the last argument in EAX.
 static void TestLastArgumentIsDouble(Assembler* assembler,
                                      Label* is_smi,
                                      Label* not_double_smi) {
   __ movl(EAX, Address(ESP, + 1 * kWordSize));
   __ testl(EAX, Immediate(kSmiTagMask));
   __ j(ZERO, is_smi, Assembler::kNearJump);  // Jump if Smi.
-  __ LoadObject(EBX, Class::ZoneHandle(
-      Isolate::Current()->object_store()->double_class()));
-  __ cmpl(EBX, FieldAddress(EAX, Object::class_offset()));
+  __ CompareClassOf(EAX, Class::Handle(
+      Isolate::Current()->object_store()->double_class()), EBX);
   __ j(NOT_EQUAL, not_double_smi, Assembler::kNearJump);
   // Fall through if double.
 }
 
 
 // Both arguments on stack, arg0 (left) is a double, arg1 (right) is of unknown
 // type. Return true or false object in the register EAX. Any NaN argument
 // returns false. Any non-double arg1 causes control flow to fall through to the
 // slow case (compiled method body).
 static bool CompareDoubles(Assembler* assembler, Condition true_condition) {
@@ skipping 402 matching lines @@
   ObjectStore* object_store = Isolate::Current()->object_store();
   Label fall_through;
   __ movl(EBX, Address(ESP, + 1 * kWordSize));  // Index.
   __ movl(EAX, Address(ESP, + 2 * kWordSize));  // String.
   __ testl(EBX, Immediate(kSmiTagMask));
   __ j(NOT_ZERO, &fall_through, Assembler::kNearJump);  // Non-smi index.
   // Range check.
   __ cmpl(EBX, FieldAddress(EAX, String::length_offset()));
   // Runtime throws exception.
   __ j(ABOVE_EQUAL, &fall_through, Assembler::kNearJump);
-  __ movl(EDI, FieldAddress(EAX, Instance::class_offset()));
-  __ CompareObject(EDI,
-      Class::ZoneHandle(object_store->one_byte_string_class()));
+  __ CompareClassOf(EAX,
+                    Class::Handle(object_store->one_byte_string_class()),
+                    EDI);
   __ j(NOT_EQUAL, &fall_through);
   __ SmiUntag(EBX);
   __ movzxb(EAX, FieldAddress(EAX, EBX, TIMES_1, OneByteString::data_offset()));
   __ SmiTag(EAX);
   __ ret();
   __ Bind(&fall_through);
   return false;
 }
 
 
@@ skipping 24 matching lines @@
   __ Bind(&is_true);
   __ LoadObject(EAX, bool_true);
   __ ret();
   return true;
 }
 
 #undef __
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32