Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.h

Issue 10450012: Apply a CursorRect to the extent of the render widget view for web page cursors. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mac.h
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.h b/content/browser/renderer_host/render_widget_host_view_mac.h
index 54e96af51fdda1bd9be4a8d08e55306264c9b399..7f7dc8d62dc3096c7937aba6e35d6cbcf4a14b7b 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.h
+++ b/content/browser/renderer_host/render_widget_host_view_mac.h
@@ -66,6 +66,9 @@ class RenderWidgetHostImpl;
NSWindow* lastWindow_; // weak
+ // The cursor for the page. This is passed up from the renderer.
+ NSCursor* current_cursor_;
Avi (use Gerrit) 2012/05/24 15:14:49 Rather than the retains/releases in the .mm, you s
+
// Variables used by our implementaion of the NSTextInput protocol.
// An input method of Mac calls the methods of this protocol not only to
// notify an application of its status, but also to retrieve the status of
@@ -154,7 +157,7 @@ class RenderWidgetHostImpl;
// Evaluates the event in the context of plugin IME, if plugin IME is enabled.
// Returns YES if the event was handled.
- (BOOL)postProcessEventForPluginIme:(NSEvent*)event;
-
+- (void)updateCursor:(NSCursor*)cursor;
@end
///////////////////////////////////////////////////////////////////////////////
@@ -382,9 +385,6 @@ class RenderWidgetHostViewMac : public content::RenderWidgetHostViewBase {
// Returns whether this render view is a popup (autocomplete window).
bool IsPopup() const;
- // Updates the display cursor if the current event is over the view's window.
- void UpdateCursorIfNecessary();
-
// Shuts down the render_widget_host_. This is a separate function so we can
// invoke it from the message loop.
void ShutdownHost();
@@ -398,9 +398,6 @@ class RenderWidgetHostViewMac : public content::RenderWidgetHostViewBase {
// to own this RenderWidgetHostViewMac object.
RenderWidgetHostViewCocoa* cocoa_view_;
- // The cursor for the page. This is passed up from the renderer.
- WebCursor current_cursor_;
-
// Indicates if the page is loading.
bool is_loading_;

Powered by Google App Engine
This is Rietveld 408576698