Transfer user agent override info between browser and renderer

content/renderer/render_view_impl.h

Index: content/renderer/render_view_impl.h
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h
index bc2dc0ac9403073c51b510fbee9b6f661be2621b..707ca3ca835895bbb260878fcbd70d5e2a5e4db1 100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -198,6 +198,7 @@ class RenderViewImpl : public RenderWidget,
       int32 surface_id,
       int64 session_storage_namespace_id,
       const string16& frame_name,
+      const std::string& user_agent_override,
       bool is_renderer_created,
       bool swapped_out,
       int32 next_page_id,
@@ -630,6 +631,8 @@ class RenderViewImpl : public RenderWidget,
       WebKit::WebFrame* source,
       WebKit::WebSecurityOrigin targetOrigin,
       WebKit::WebDOMMessageEvent event) OVERRIDE;
+  virtual bool userAgent(const WebKit::WebURL& url,

[Charlie Reis, 2012/06/01 00:36:08]

That function name doesn't indicate what it's doing.  I realize this would be a
task for a separate WebKit patch, but could the name reflect more of what
question it's answering?

[gone, 2012/06/01 01:04:06]

This appears to be the naming convention for accessing the user agent for a few
classes in WebKit... we could try to change it to userAgentOverride() or
something.

[Charlie Reis, 2012/06/01 18:04:09]

Most of those appear to return a String, which makes sense to me (i.e.,
userAgent() returns the user agent string).  This one returns a bool indicating
whether to use a custom userAgent.  Or is that an out parameter?  Either way, it
feels different than a normal accessor.

Maybe something like shouldOverrideUserAgent()?  Anyway, this is probably
Darin's territory for WebKit API, so we can defer it for this CL.

[gone, 2012/06/14 00:46:39]

https://bugs.webkit.org/show_bug.cgi?id=89028

+                         WebKit::WebString* userAgent) OVERRIDE;
 
   // WebKit::WebPageSerializerClient implementation ----------------------------
 
@@ -784,6 +787,7 @@ class RenderViewImpl : public RenderWidget,
                  int32 surface_id,
                  int64 session_storage_namespace_id,
                  const string16& frame_name,
+                 const std::string& user_agent_override,
                  bool is_renderer_created,
                  bool swapped_out,
                  int32 next_page_id,
@@ -941,6 +945,7 @@ class RenderViewImpl : public RenderWidget,
   void OnScrollFocusedEditableNodeIntoRect(const gfx::Rect& rect);
   void OnSetPageEncoding(const std::string& encoding_name);
   void OnSetRendererPrefs(const content::RendererPreferences& renderer_prefs);
+  void OnSetUserAgentOverride(const std::string& override);
 #if defined(OS_MACOSX)
   void OnSetWindowVisibility(bool visible);
 #endif
@@ -1102,6 +1107,12 @@ class RenderViewImpl : public RenderWidget,
   // should be drawn.
   gfx::Size disable_scrollbars_size_limit_;
 
+  // String to use when overriding the default user agent.
+  std::string user_agent_override_;
+
+  // Whether or not the override is being used.
+  bool is_overriding_user_agent_;
+
   // Loading state -------------------------------------------------------------
 
   // True if the top level frame is currently being loaded.