Transfer user agent override info between browser and renderer

content/public/browser/navigation_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_
 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 149 matching lines @@
                        PageTransition type,
                        const std::string& extra_headers) = 0;
 
   // Same as LoadURL, but for renderer-initiated navigations.  This state is
   // important for tracking whether to display pending URLs.
   virtual void LoadURLFromRenderer(const GURL& url,
                                    const Referrer& referrer,
                                    PageTransition type,
                                    const std::string& extra_headers) = 0;
 
+  // Same as LoadURL, but allows overriding the user agent of the
+  // NavigationEntry before it loads.
+  virtual void LoadURLWithUserAgentOverride(const GURL& url,

[darin (slow to review), 2012/06/19 18:36:34]

it feels like we might be getting to the point where there should be a single
LoadURL function that takes a parameters class.  dunno.

[gone, 2012/06/19 21:44:22]

Yeah, there's some discussion on the interfaces being added in
https://chromiumcodereview.appspot.com/10544175/.  It seems like all the
functions are trying to work around having to add custom parameters to the
NavigationEntry before it gets sent off.

[Charlie Reis, 2012/06/19 22:47:59]

I think I agree.  LoadURLWithUserAgentOverride now has a is_renderer_initiated
parameter, so it supersedes LoadURL and LoadURLFromRenderer.  Even if we didn't
add a parameters class yet, I bet we could rename this one to LoadURL and
replace the other two.

(Then again, that might touch a ton of code.  If so, maybe it could be left for
a follow-up CL?)

[gone, 2012/06/20 00:01:10]

Yeah, if this replaces LoadURL, it should definitely be done as a follow up CL;
the current LoadURL() is called from all over the place.

[Charlie Reis, 2012/06/20 00:17:52]

Sure.  Maybe just add a TODO for now, to be sure it doesn't get forgotten.

+                                            const Referrer& referrer,
+                                            PageTransition type,
+                                            bool is_renderer_initiated,
+                                            const std::string& extra_headers,
+                                            bool is_overriding_user_agent) = 0;
+
   // Behaves like LoadURL() and LoadURLFromRenderer() but marks the new
   // navigation as being transferred from one RVH to another. In this case the
   // browser can recycle the old request once the new renderer wants to
   // navigate.
   // |transferred_global_request_id| identifies the request ID of the old
   // request.
   virtual void TransferURL(
       const GURL& url,
       const Referrer& referrer,
       PageTransition transition,
@@ skipping 80 matching lines @@
   virtual void CopyStateFromAndPrune(NavigationController* source) = 0;
 
   // Removes all the entries except the active entry. If there is a new pending
   // navigation it is preserved.
   virtual void PruneAllButActive() = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_