Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Unified Diff: vm/code_generator_ia32.cc

Issue 10449106: Remove unused function GeneratePreEntryCode from ia32 code generator. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/code_generator_ia32.h ('k') | vm/opt_code_generator_ia32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/code_generator_ia32.cc
===================================================================
--- vm/code_generator_ia32.cc (revision 8186)
+++ vm/code_generator_ia32.cc (working copy)
@@ -217,20 +217,6 @@
}
-// Pre entry code is called before the frame has been constructed:
-// - check for stack overflow.
-// - optionally count function invocations.
-// - optionally trigger optimizing compiler if invocation threshold has been
-// reached.
-// Note that first 5 bytes may be patched with a jump.
-// TODO(srdjan): Add check that no object is inlined in the first
-// 5 bytes (length of a jump instruction).
-void CodeGenerator::GeneratePreEntryCode() {
- // TODO(srdjan): Still needed?
- __ nop(5);
-}
-
-
void CodeGenerator::FinalizePcDescriptors(const Code& code) {
ASSERT(pc_descriptors_list_ != NULL);
const PcDescriptors& descriptors = PcDescriptors::Handle(
« no previous file with comments | « vm/code_generator_ia32.h ('k') | vm/opt_code_generator_ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698