Issue 10449103: Update the DOMStorageContext public interface in the content layer to remove FilePaths and origin_i…

Issue 10449103: Update the DOMStorageContext public interface in the content layer to remove FilePaths and origin_i… (Closed)

Created:
8 years, 6 months ago by michaeln

Modified:
8 years, 6 months ago

Reviewers:
jochen (gone - plz use gerrit), jam, Mike West

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Update the DOMStorageContext public interface in the content layer to remove FilePaths and origin_identifier strings. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140117

Patch Set 3 : #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -16 lines)			Patch
M	content/browser/dom_storage/dom_storage_context_impl.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/dom_storage/dom_storage_context_impl.cc	View	1 2	2 chunks	+37 lines, -0 lines	0 comments	Download
M	content/public/browser/dom_storage_context.h	View	1 2	2 chunks	+9 lines, -16 lines	1 comment	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

michaeln

https://chromiumcodereview.appspot.com/10449103/diff/1/content/public/browser/dom_storage_context.h File content/public/browser/dom_storage_context.h (right): https://chromiumcodereview.appspot.com/10449103/diff/1/content/public/browser/dom_storage_context.h#newcode19 content/public/browser/dom_storage_context.h:19: class Time; i've added the #include for base/time.h locally

8 years, 6 months ago (2012-06-01 01:47:44 UTC) #2

Mike West

LGTM. Thanks for doing this. It'll dramatically simplify the code in the other CL. On ...

8 years, 6 months ago (2012-06-01 07:31:08 UTC) #3

jochen (gone - plz use gerrit)

drive-by content nits http://codereview.chromium.org/10449103/diff/4002/content/browser/dom_storage/dom_storage_context_impl.cc File content/browser/dom_storage/dom_storage_context_impl.cc (right): http://codereview.chromium.org/10449103/diff/4002/content/browser/dom_storage/dom_storage_context_impl.cc#newcode26 content/browser/dom_storage/dom_storage_context_impl.cc:26: namespace content { eventually, all code ...

8 years, 6 months ago (2012-06-01 11:00:44 UTC) #4

michaeln

@jam, ptal... changed to utilize the dom_storage type for UsageInfo like we talked about

8 years, 6 months ago (2012-06-01 20:38:05 UTC) #5

jam

lgtm http://codereview.chromium.org/10449103/diff/12001/content/public/browser/dom_storage_context.h File content/public/browser/dom_storage_context.h (right): http://codereview.chromium.org/10449103/diff/12001/content/public/browser/dom_storage_context.h#newcode29 content/public/browser/dom_storage_context.h:29: virtual void GetUsageInfo(const GetUsageInfoCallback& callback) = 0; nit: ...

8 years, 6 months ago (2012-06-01 21:58:37 UTC) #6

michaeln

8 years, 6 months ago (2012-06-01 22:07:30 UTC) #7

> nit: please add comments for both of these methods

done

Expand Messages | Collapse Messages