Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 10449077: Set "Hover" status during focus for accessibility. (Closed)

Created:
8 years, 6 months ago by Jun Mukai
Modified:
8 years, 6 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Set "Hover" status during focus for accessibility. Based on the discussion on crbug.com/120499, we'd better to set the "hover" status to the launcher items when focused. This CL keeps the dotted rectangle too. R=zork@chromium.org,davemoore@chromium.org BUG=120499 TEST=manually verified Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141166

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M ash/launcher/launcher_button.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M ash/launcher/launcher_button.cc View 1 2 3 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
DaveMoore
I believe that if you focus and blur while the mouse is still over the ...
8 years, 6 months ago (2012-05-31 00:07:30 UTC) #1
Jun Mukai
Oh I see. Then Added a new "STATE_FOCUSED".
8 years, 6 months ago (2012-05-31 02:10:19 UTC) #2
Zachary Kuznia
lgtm
8 years, 6 months ago (2012-05-31 08:12:07 UTC) #3
Jun Mukai
Dave, could you make progress of the code review on this CL? It fixes according ...
8 years, 6 months ago (2012-05-31 20:23:18 UTC) #4
Jun Mukai
ping?
8 years, 6 months ago (2012-06-06 15:26:44 UTC) #5
DaveMoore
lgtm
8 years, 6 months ago (2012-06-07 16:31:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/10449077/1003
8 years, 6 months ago (2012-06-08 01:08:39 UTC) #7
commit-bot: I haz the power
Failed to apply patch for ash/launcher/launcher_button.h: While running patch -p1 --forward --force; patching file ash/launcher/launcher_button.h ...
8 years, 6 months ago (2012-06-08 01:08:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/10449077/8003
8 years, 6 months ago (2012-06-08 01:28:49 UTC) #9
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 03:46:49 UTC) #10
Change committed as 141166

Powered by Google App Engine
This is Rietveld 408576698