Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 10449020: Support using the HEAD request in the HTTP library (Closed)

Created:
8 years, 7 months ago by Søren Gjesse
Modified:
8 years, 7 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support using the HEAD request in the HTTP library There was a number of issues in relation to using the HTTP method HEAD * The HTTP parser did not parse HEAD correctly * HEAD respoonse could not have a content length and empty body * The client could not receive a HEAD response with content length an empty body I the server we support writing to the output stream when replying to a head request. They should now be fixed and a test for HEAD have been added R=ager@google.com BUG=dart:3205 TEST=tests/standalone/io/http_head_test.dart, tests/standalone/io/http_parser_test.dart Committed: https://code.google.com/p/dart/source/detail?r=7986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -37 lines) Patch
M runtime/bin/http_impl.dart View 11 chunks +16 lines, -9 lines 0 comments Download
M runtime/bin/http_parser.dart View 3 chunks +12 lines, -5 lines 0 comments Download
A tests/standalone/io/http_head_test.dart View 1 chunk +54 lines, -0 lines 0 comments Download
M tests/standalone/io/http_parser_test.dart View 1 chunk +15 lines, -23 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
8 years, 7 months ago (2012-05-25 09:39:35 UTC) #1
Mads Ager (google)
8 years, 7 months ago (2012-05-25 10:06:12 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698