Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 10449008: Allow user script install by dragging onto chrome://extensions/. (Closed)

Created:
8 years, 7 months ago by Aaron Boodman
Modified:
8 years, 6 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Allow user script install by dragging onto chrome://extensions/. Because otherwise, when off-store extension install is disabled, there is no way to install user scripts. BUG=55584 TEST=Run chrome with --enable-off-store-extension-install=0, navigate to a .user.js file. Should see error. Now download that file and drag onto chrome://extensions/. Should be offered a drop target, and install should proceed when dropped. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139640

Patch Set 1 #

Patch Set 2 : um #

Total comments: 2

Patch Set 3 : opps #

Patch Set 4 : use correct base #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M chrome/browser/resources/extensions/extensions.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/install_extension_handler.cc View 1 2 3 3 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Aaron Boodman
8 years, 6 months ago (2012-05-28 18:09:47 UTC) #1
Yoyo Zhou
http://codereview.chromium.org/10449008/diff/1003/chrome/browser/ui/webui/extensions/install_extension_handler.cc File chrome/browser/ui/webui/extensions/install_extension_handler.cc (right): http://codereview.chromium.org/10449008/diff/1003/chrome/browser/ui/webui/extensions/install_extension_handler.cc#newcode103 chrome/browser/ui/webui/extensions/install_extension_handler.cc:103: CHECK(false); Did you mean to put this in a ...
8 years, 6 months ago (2012-05-29 19:08:11 UTC) #2
Aaron Boodman
http://codereview.chromium.org/10449008/diff/1003/chrome/browser/ui/webui/extensions/install_extension_handler.cc File chrome/browser/ui/webui/extensions/install_extension_handler.cc (right): http://codereview.chromium.org/10449008/diff/1003/chrome/browser/ui/webui/extensions/install_extension_handler.cc#newcode103 chrome/browser/ui/webui/extensions/install_extension_handler.cc:103: CHECK(false); On 2012/05/29 19:08:12, Yoyo Zhou wrote: > Did ...
8 years, 6 months ago (2012-05-30 00:42:50 UTC) #3
Yoyo Zhou
8 years, 6 months ago (2012-05-30 00:46:32 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698