Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in

Issue 10449008: Allow user script install by dragging onto chrome://extensions/. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
5 years, 1 month ago by Aaron Boodman
5 years ago
Yoyo Zhou
chromium-reviews, Aaron Boodman,, arv (Not doing code reviews)


Allow user script install by dragging onto chrome://extensions/. Because otherwise, when off-store extension install is disabled, there is no way to install user scripts. BUG=55584 TEST=Run chrome with --enable-off-store-extension-install=0, navigate to a .user.js file. Should see error. Now download that file and drag onto chrome://extensions/. Should be offered a drop target, and install should proceed when dropped. Committed:

Patch Set 1 #

Patch Set 2 : um #

Total comments: 2

Patch Set 3 : opps #

Patch Set 4 : use correct base #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M chrome/browser/resources/extensions/extensions.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/ View 1 2 3 3 chunks +20 lines, -1 line 0 comments Download
Commit queue not available (can’t edit this change).


Total messages: 4 (0 generated)
Aaron Boodman
5 years ago (2012-05-28 18:09:47 UTC) #1
Yoyo Zhou File chrome/browser/ui/webui/extensions/ (right): chrome/browser/ui/webui/extensions/ CHECK(false); Did you mean to put this in a ...
5 years ago (2012-05-29 19:08:11 UTC) #2
Aaron Boodman File chrome/browser/ui/webui/extensions/ (right): chrome/browser/ui/webui/extensions/ CHECK(false); On 2012/05/29 19:08:12, Yoyo Zhou wrote: > Did ...
5 years ago (2012-05-30 00:42:50 UTC) #3
Yoyo Zhou
5 years ago (2012-05-30 00:46:32 UTC) #4
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318