Issue 10448117: Limit work done analyzing regexps with very large fanout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10448117: Limit work done analyzing regexps with very large fanout. (Closed)

Created:
8 years, 6 months ago by Erik Corry

Modified:
8 years, 6 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Limit work done analyzing regexps with very large fanout. BUG=128821 Committed: https://code.google.com/p/v8/source/detail?r=11696

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -9 lines)			Patch
M	src/jsregexp.h	View	10 chunks	+14 lines, -2 lines	1 comment	Download
M	src/jsregexp.cc	View	10 chunks	+20 lines, -7 lines	1 comment	Download
M	test/mjsunit/regexp-capture.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ulan

8 years, 6 months ago (2012-06-01 11:24:04 UTC) #2

LGTM with comments.

https://chromiumcodereview.appspot.com/10448117/diff/1/src/jsregexp.cc
File src/jsregexp.cc (right):

https://chromiumcodereview.appspot.com/10448117/diff/1/src/jsregexp.cc#newcod...
src/jsregexp.cc:2826: offset, recursion_depth + 1, budget, bm, not_at_start);
We either need to decrement the budget or add a comment why it is not necessary.

https://chromiumcodereview.appspot.com/10448117/diff/1/src/jsregexp.h
File src/jsregexp.h (right):

https://chromiumcodereview.appspot.com/10448117/diff/1/src/jsregexp.h#newcode587
src/jsregexp.h:587: int budget,
Please add a description for budget.

Expand Messages | Collapse Messages