Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 10448114: Merge 117825 - Don't force rendering in finishAllRendering (Closed)

Created:
8 years, 6 months ago by piman
Modified:
8 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Visibility:
Public.

Description

Merge 117825 - Don't force rendering in finishAllRendering https://bugs.webkit.org/show_bug.cgi?id=86919 Reviewed by James Robinson. After we acquire the texture layers on the main thread, we can't draw. In particular if we destroyed the texture ids used previously by TextureLayerChromium, drawing before a commit would cause a bind-after-destroy. Tested by CCLayerTreeHostTestFinishAllRendering. * platform/graphics/chromium/cc/CCThreadProxy.cpp: (WebCore::CCThreadProxy::CCThreadProxy): (WebCore::CCThreadProxy::finishAllRenderingOnImplThread): (WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal): TBR=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119176

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp View 3 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
piman
8 years, 6 months ago (2012-06-01 00:02:28 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698