Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 10448097: Revert r11681 https://chromiumcodereview.appspot.com/10448011 (Closed)

Created:
8 years, 6 months ago by Erik Corry
Modified:
8 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Revert r11681 https://chromiumcodereview.appspot.com/10448011 (Keep track of which maps are associated with prototype objects so we can tune the fast-case vs. hash map heuristics accordingly.). Reverting because the dict-mode to fast case transformation loses the iteration order information. Committed: https://code.google.com/p/v8/source/detail?r=11685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -219 lines) Patch
M src/objects.h View 6 chunks +4 lines, -24 lines 0 comments Download
M src/objects.cc View 7 chunks +11 lines, -64 lines 0 comments Download
M src/objects-inl.h View 3 chunks +3 lines, -26 lines 0 comments Download
M src/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +5 lines, -10 lines 0 comments Download
D test/mjsunit/fast-prototype.js View 1 chunk +0 lines, -92 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
8 years, 6 months ago (2012-05-31 09:22:17 UTC) #1
Michael Starzinger
8 years, 6 months ago (2012-05-31 09:23:49 UTC) #2
LGTM (rubber-stamped).

Powered by Google App Engine
This is Rietveld 408576698