Address review comments in commited cl (issue 10460002).

runtime/vm/stub_code_ia32.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/assembler.h"
 #include "vm/assembler_macros.h"
 #include "vm/code_generator.h"
@@ skipping 1278 matching lines @@
   __ popl(EAX);  // Pop result (newly allocated object).
   // EAX: new object
   // Restore the frame pointer.
   __ LeaveFrame();
   __ ret();
 }
 
 
 // Called for inline allocation of closures.
 // Input parameters:
-//   If the signature class is not parameterized, the receiver, if any, will be
-//   at ESP + 4 instead of ESP + 8, since no type arguments are passed.
-//   ESP + 8 (or ESP + 4): receiver (only if implicit instance closure).
-//   ESP + 4 : type arguments object (only if signature class is parameterized).
+//   ESP + 8 : receiver (only if implicit instance closure).
+//   ESP + 4 : type arguments object (null if class is no parameterized).
 //   ESP : points to return address.
 // Uses EAX, EBX, ECX, EDX as temporary registers.
 void StubCode::GenerateAllocationStubForClosure(Assembler* assembler,
                                                 const Function& func) {
   const Immediate raw_null =
       Immediate(reinterpret_cast<intptr_t>(Object::null()));
   ASSERT(func.IsClosureFunction());
   const bool is_implicit_static_closure =
       func.IsImplicitStaticClosureFunction();
   const bool is_implicit_instance_closure =
       func.IsImplicitInstanceClosureFunction();
   const Class& cls = Class::ZoneHandle(func.signature_class());
   const bool has_type_arguments = cls.HasTypeArguments();
   const intptr_t kTypeArgumentsOffset = 1 * kWordSize;
-  const intptr_t kReceiverOffset = (has_type_arguments ? 2 : 1) * kWordSize;
+  const intptr_t kReceiverOffset = 2 * kWordSize;
   const intptr_t closure_size = Closure::InstanceSize();
   const intptr_t context_size = Context::InstanceSize(1);  // Captured receiver.
   if (FLAG_inline_alloc &&
       PageSpace::IsPageAllocatableSize(closure_size + context_size)) {
     Label slow_case;
     Heap* heap = Isolate::Current()->heap();
     __ movl(EAX, Address::Absolute(heap->TopAddress()));
     __ leal(EBX, Address(EAX, closure_size));
     if (is_implicit_instance_closure) {
       __ movl(ECX, EBX);  // ECX: new context address.
@@ skipping 68 matching lines @@
       __ movl(Address(ECX, Context::variable_offset(0)), EDX);
 
       // Set the newly allocated context in the newly allocated closure.
       __ addl(ECX, Immediate(kHeapObjectTag));
       __ movl(Address(EAX, Closure::context_offset()), ECX);
     } else {
       __ movl(Address(EAX, Closure::context_offset()), CTX);
     }
 
     // Set the type arguments field in the newly allocated closure.
-    if (has_type_arguments) {
-      ASSERT(!is_implicit_static_closure);
-      // Use the passed-in type arguments.
-      __ movl(EDX, Address(ESP, kTypeArgumentsOffset));
-      __ movl(Address(EAX, Closure::type_arguments_offset()), EDX);
-    } else {
-      // Set to null.
-      __ movl(Address(EAX, Closure::type_arguments_offset()), raw_null);
-    }
+    __ movl(EDX, Address(ESP, kTypeArgumentsOffset));
+    __ movl(Address(EAX, Closure::type_arguments_offset()), EDX);
 
     __ movl(Address(EAX, Closure::smrck_offset()), raw_null);
 
     // Done allocating and initializing the instance.
     // EAX: new object.
     __ addl(EAX, Immediate(kHeapObjectTag));
     __ ret();
 
     __ Bind(&slow_case);
   }
@@ skipping 467 matching lines @@
 // TOS + 2: instance.
 // TOS + 3: cache array.
 // Result in ECX: null -> not found, otherwise result (true or false).
 void StubCode::GenerateSubtype3TestCacheStub(Assembler* assembler) {
   GenerateSubtypeNTestCacheStub(assembler, 3);
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32