Address review comments in commited cl (issue 10460002).

runtime/vm/intermediate_language.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_INTERMEDIATE_LANGUAGE_H_
 #define VM_INTERMEDIATE_LANGUAGE_H_
 
 #include "vm/allocation.h"
 #include "vm/ast.h"
 #include "vm/growable_array.h"
@@ skipping 990 matching lines @@
   const intptr_t token_index_;
   const intptr_t try_index_;
   ZoneGrowableArray<Value*>* const elements_;
 
   DISALLOW_COPY_AND_ASSIGN(CreateArrayComp);
 };
 
 
 class CreateClosureComp : public Computation {
  public:
-  // 'type_arguments' is null if function() does not require type arguments.
   CreateClosureComp(ClosureNode* node,
                     intptr_t try_index,
                     Value* type_arguments)
       : ast_node_(*node),
         try_index_(try_index),
-        type_arguments_(type_arguments) {}
+        type_arguments_(type_arguments) {
+    ASSERT(type_arguments != NULL);
+  }
 
   DECLARE_COMPUTATION(CreateClosure)
 
   intptr_t token_index() const { return ast_node_.token_index(); }
   intptr_t try_index() const { return try_index_; }
   const Function& function() const { return ast_node_.function(); }
   Value* type_arguments() const { return type_arguments_; }
 
   virtual intptr_t InputCount() const;
   virtual Value* InputAt(intptr_t i) const {
     return i == 0 ? type_arguments() : NULL;

[srdjan, 2012/05/30 17:19:43]

InputCount can be two, but InputAt(1) is always NULL?  It is weird that the
receiver is input argument sometimes, but is not visible/referrable in the
CreateClosureComp. Any ideas how to solve it?

[regis, 2012/05/30 18:08:34]

I changed CreateClosureComp to be a TemplateComputation<2>. The receiver is now
always passed to the stub, as null if necessary.

   }
 
   virtual void PrintOperandsTo(BufferFormatter* f) const;
 
  private:
   const ClosureNode& ast_node_;
   const intptr_t try_index_;
   Value* type_arguments_;
 
   DISALLOW_COPY_AND_ASSIGN(CreateClosureComp);
@@ skipping 852 matching lines @@
   const GrowableArray<BlockEntryInstr*>& block_order_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(FlowGraphVisitor);
 };
 
 
 }  // namespace dart
 
 #endif  // VM_INTERMEDIATE_LANGUAGE_H_