Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Side by Side Diff: runtime/vm/intermediate_language.cc

Issue 10448059: Use temporary variable for StoreIndexed that returns a value. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/intermediate_language.h" 5 #include "vm/intermediate_language.h"
6 6
7 #include "vm/bit_vector.h" 7 #include "vm/bit_vector.h"
8 #include "vm/flow_graph_builder.h" 8 #include "vm/flow_graph_builder.h"
9 #include "vm/object.h" 9 #include "vm/object.h"
10 #include "vm/os.h" 10 #include "vm/os.h"
(...skipping 363 matching lines...) Expand 10 before | Expand all | Expand 10 after
374 374
375 RawAbstractType* NativeCallComp::StaticType() const { 375 RawAbstractType* NativeCallComp::StaticType() const {
376 // The result type of the native function is identical to the result type of 376 // The result type of the native function is identical to the result type of
377 // the enclosing native Dart function. However, we prefer to check the type 377 // the enclosing native Dart function. However, we prefer to check the type
378 // of the value returned from the native call. 378 // of the value returned from the native call.
379 return Type::DynamicType(); 379 return Type::DynamicType();
380 } 380 }
381 381
382 382
383 RawAbstractType* StoreIndexedComp::StaticType() const { 383 RawAbstractType* StoreIndexedComp::StaticType() const {
384 return value()->StaticType(); 384 UNREACHABLE();
385 return AbstractType::null();
385 } 386 }
386 387
387 388
388 RawAbstractType* InstanceSetterComp::StaticType() const { 389 RawAbstractType* InstanceSetterComp::StaticType() const {
389 return value()->StaticType(); 390 return value()->StaticType();
390 } 391 }
391 392
392 393
393 RawAbstractType* StaticSetterComp::StaticType() const { 394 RawAbstractType* StaticSetterComp::StaticType() const {
394 const AbstractType& assigned_value_type = 395 const AbstractType& assigned_value_type =
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
538 } 539 }
539 540
540 541
541 RawAbstractType* BinaryOpComp::StaticType() const { 542 RawAbstractType* BinaryOpComp::StaticType() const {
542 // TODO(srdjan): Compute based on input types (ICData). 543 // TODO(srdjan): Compute based on input types (ICData).
543 return Type::DynamicType(); 544 return Type::DynamicType();
544 } 545 }
545 546
546 547
547 } // namespace dart 548 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698