Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 10448048: Revert "Add some temporary code to work around an error in test scripts, to fix buildbots." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 37625df6e83f66821243ce2d2a909084ffad4dba..61302ab9269bcf635f8c0b5a882cab7f8121fba8 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -730,11 +730,6 @@ class BatchRunnerProcess {
}
void _testCompleted() {
- // TODO(3286): Remove this temporary code used to diagnose problem.
- if (!_stdoutDrained || !_stderrDrained) {
- print("Warning: Batch Test Runner problem:\n"
- " _stdoutDrained: $_stdoutDrained, _stderrDrained: $_stderrDrained");
- }
var test = _currentTest;
_currentTest = null;
test.completed();
@@ -747,23 +742,9 @@ class BatchRunnerProcess {
var exitCode = 0;
if (outcome == "CRASH") exitCode = -10;
if (outcome == "FAIL" || outcome == "TIMEOUT") exitCode = 1;
- // TODO(3286): Remove this temporary code used to diagnose problem.
- if (_currentTest == null) {
- print("Warning: Batch Test Runner problem:\n"
- " _currentTest is null\n"
- " Stdout:");
- for (var line in _testStdout) {
- print(line);
- }
- print(" Stderr:");
- for (var line in _testStderr) {
- print(line);
- }
- } else {
- new TestOutput.fromCase(_currentTest, exitCode, (outcome == "TIMEOUT"),
- _testStdout, _testStderr,
- new Date.now().difference(_startTime));
- }
+ new TestOutput.fromCase(_currentTest, exitCode, (outcome == "TIMEOUT"),
+ _testStdout, _testStderr,
+ new Date.now().difference(_startTime));
// Move on when both stdout and stderr has been drained. If the test
// crashed, we restarted the process and therefore do not attempt to
// drain stderr.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698