Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 10448044: Use trace_child_process.py on Windows and save information about the trace in json. (Closed)

Created:
8 years, 6 months ago by M-A Ruel
Modified:
8 years, 6 months ago
Reviewers:
cmp, MAD
CC:
chromium-reviews, pam+watch_chromium.org, csharp
Visibility:
Public.

Description

Use trace_child_process.py on Windows and save information about the trace in json. Removes much of the guesswork in the log parsing code, now the child process id is known. Remove references to logman.exe in the log parsing script since it's now called by the grand-parent process. NOTRY=true R=cmp@chromium.org BUG=98636 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140421

Patch Set 1 #

Total comments: 4

Patch Set 2 : Added more comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -102 lines) Patch
M tools/isolate/trace_child_process.py View 1 1 chunk +16 lines, -14 lines 0 comments Download
M tools/isolate/trace_inputs.py View 1 11 chunks +86 lines, -88 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
8 years, 6 months ago (2012-05-29 00:26:19 UTC) #1
cmp
lgtm with nits https://chromiumcodereview.appspot.com/10448044/diff/1/tools/isolate/trace_child_process.py File tools/isolate/trace_child_process.py (right): https://chromiumcodereview.appspot.com/10448044/diff/1/tools/isolate/trace_child_process.py#newcode6 tools/isolate/trace_child_process.py:6: """Waits for the go signal and ...
8 years, 6 months ago (2012-06-04 22:15:34 UTC) #2
M-A Ruel
https://chromiumcodereview.appspot.com/10448044/diff/1/tools/isolate/trace_child_process.py File tools/isolate/trace_child_process.py (right): https://chromiumcodereview.appspot.com/10448044/diff/1/tools/isolate/trace_child_process.py#newcode6 tools/isolate/trace_child_process.py:6: """Waits for the go signal and replaces itself with ...
8 years, 6 months ago (2012-06-04 23:18:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10448044/5001
8 years, 6 months ago (2012-06-04 23:18:36 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-04 23:19:55 UTC) #5
Change committed as 140421

Powered by Google App Engine
This is Rietveld 408576698