Issue 10448042: Add a few early exits to ExpandVariables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10448042: Add a few early exits to ExpandVariables. (Closed)

Created:
8 years, 6 months ago by Nico

Modified:
8 years, 6 months ago

Reviewers:
scottmg

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add a few early exits to ExpandVariables. This makes the functions a bit less indented. No functionality change. Committed: https://code.google.com/p/gyp/source/detail?r=1402

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+239 lines, -235 lines)			Patch
	M	pylib/gyp/input.py	View		1 chunk	+239 lines, -235 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

https://chromiumcodereview.appspot.com/10448042/diff/1/pylib/gyp/input.py File pylib/gyp/input.py (right): https://chromiumcodereview.appspot.com/10448042/diff/1/pylib/gyp/input.py#newcode554 pylib/gyp/input.py:554: # Reverse the list of matches so that replacements ...

8 years, 6 months ago (2012-05-28 21:54:50 UTC) #1

scottmg

8 years, 6 months ago (2012-05-28 22:10:14 UTC) #2

yikes that's hard to read. I don't see any changes in behaviour, but kind of
unfortunate.

lgtm

Expand Messages | Collapse Messages