Issue 10448041: Speed up gyp 10% by removing a debug statement that's never used for anything in practice.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10448041: Speed up gyp 10% by removing a debug statement that's never used for anything in practice. (Closed)

Created:
8 years, 6 months ago by Nico

Modified:
8 years, 6 months ago

Reviewers:
scottmg

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Speed up gyp 10% by removing a debug statement that's never used for anything in practice. If someone wants to debug this, they can just add a local print statement. 32s -> 29.5s for ninjagyp on my machine. BUG=chromium:82230 TEST=none Committed: https://code.google.com/p/gyp/source/detail?r=1400

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	pylib/gyp/input.py	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

scottmg

8 years, 6 months ago (2012-05-28 21:23:48 UTC) #2

I had no idea that existed... Just the string formatting and function call is 3s
worth? sigh.

lgtm

Expand Messages | Collapse Messages