Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 10448040: Add histogram for off-store installation disallowed. (Closed)

Created:
8 years, 6 months ago by Aaron Boodman
Modified:
8 years, 6 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Add histogram for off-store installation disallowed. BUG=55584 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139641

Patch Set 1 #

Patch Set 2 : warning #

Total comments: 2

Patch Set 3 : constance #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -5 lines) Patch
M chrome/browser/extensions/crx_installer.cc View 1 2 3 chunks +30 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Aaron Boodman
I'm going to do a similar change on the branch so that we can compare.
8 years, 6 months ago (2012-05-28 19:07:09 UTC) #1
Yoyo Zhou
LGTM http://codereview.chromium.org/10448040/diff/2001/chrome/browser/extensions/crx_installer.cc File chrome/browser/extensions/crx_installer.cc (right): http://codereview.chromium.org/10448040/diff/2001/chrome/browser/extensions/crx_installer.cc#newcode209 chrome/browser/extensions/crx_installer.cc:209: UMA_HISTOGRAM_ENUMERATION("Extensions.WebStoreInstallDecision", Consider making this a constant in the ...
8 years, 6 months ago (2012-05-29 18:06:02 UTC) #2
Aaron Boodman
8 years, 6 months ago (2012-05-30 00:56:01 UTC) #3
http://codereview.chromium.org/10448040/diff/2001/chrome/browser/extensions/c...
File chrome/browser/extensions/crx_installer.cc (right):

http://codereview.chromium.org/10448040/diff/2001/chrome/browser/extensions/c...
chrome/browser/extensions/crx_installer.cc:209:
UMA_HISTOGRAM_ENUMERATION("Extensions.WebStoreInstallDecision",
On 2012/05/29 18:06:02, Yoyo Zhou wrote:
> Consider making this a constant in the anonymous namespace to guard against
> typos.

Done.

Powered by Google App Engine
This is Rietveld 408576698