Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 10448037: Fix regression when off-store install is disabled. (Closed)

Created:
8 years, 6 months ago by Aaron Boodman
Modified:
8 years, 6 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Fix regression when off-store install is disabled. BUG=55584 TBR=jhawkins@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139547

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -6 lines) Patch
M chrome/browser/extensions/crx_installer.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer_browsertest.cc View 5 chunks +41 lines, -4 lines 1 comment Download
M chrome/browser/ui/webui/extensions/install_extension_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Aaron Boodman
Whoopsie
8 years, 6 months ago (2012-05-28 17:07:28 UTC) #1
Yoyo Zhou
Yeah, that looks important. LGTM http://codereview.chromium.org/10448037/diff/1/chrome/browser/extensions/crx_installer_browsertest.cc File chrome/browser/extensions/crx_installer_browsertest.cc (right): http://codereview.chromium.org/10448037/diff/1/chrome/browser/extensions/crx_installer_browsertest.cc#newcode187 chrome/browser/extensions/crx_installer_browsertest.cc:187: crx_installer->set_allow_off_store_install(true); set_allow_off_store_install(kTestData[i]);
8 years, 6 months ago (2012-05-29 18:28:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/10448037/1
8 years, 6 months ago (2012-05-30 00:48:25 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-05-30 00:48:34 UTC) #4
Presubmit check for 10448037-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui/webui

Presubmit checks took 5.1s to calculate.

Powered by Google App Engine
This is Rietveld 408576698