Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Issue 10448034: Improve tracing on OSX and Windows (Closed)

Created:
8 years, 6 months ago by M-A Ruel
Modified:
8 years, 6 months ago
Reviewers:
MAD
CC:
chromium-reviews, pam+watch_chromium.org, csharp
Visibility:
Public.

Description

Improve tracing on OSX and Windows OSX: - Make the execve more strict to be able to extract more arguments later. - Fix the initial trace to be less hacky, add strict handling of the initial process. Windows: - Only handle files that were opened by the relevant processes. Keep a threadid->processid map to be able to figure which process generated the Create event. - Only handle files that were actually opened. Detect this implicitly by looking if the file has a Cleanup event and tracking the kernel file object instances. - Add strict handling of the initial process. - Properly process \\?\ header. NOTRY=true R=mad@chromium.org BUG=98636 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139546

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 4

Patch Set 3 : reword comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -34 lines) Patch
M tools/isolate/trace_inputs.py View 1 2 18 chunks +111 lines, -34 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
8 years, 6 months ago (2012-05-28 01:34:45 UTC) #1
MAD
LGTM with a small nit on comment language... https://chromiumcodereview.appspot.com/10448034/diff/3001/tools/isolate/trace_inputs.py File tools/isolate/trace_inputs.py (right): https://chromiumcodereview.appspot.com/10448034/diff/3001/tools/isolate/trace_inputs.py#newcode1170 tools/isolate/trace_inputs.py:1170: """General ...
8 years, 6 months ago (2012-05-30 15:39:00 UTC) #2
M-A Ruel
https://chromiumcodereview.appspot.com/10448034/diff/3001/tools/isolate/trace_inputs.py File tools/isolate/trace_inputs.py (right): https://chromiumcodereview.appspot.com/10448034/diff/3001/tools/isolate/trace_inputs.py#newcode1170 tools/isolate/trace_inputs.py:1170: """General wisdom: if a file is closed, it's because ...
8 years, 6 months ago (2012-05-30 15:57:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10448034/8001
8 years, 6 months ago (2012-05-30 15:57:28 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-05-30 15:58:05 UTC) #5
Change committed as 139546

Powered by Google App Engine
This is Rietveld 408576698