Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 10448014: Fix utterly wrong comment that hasn't been true for years. (Closed)

Created:
8 years, 7 months ago by Avi (use Gerrit)
Modified:
8 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org, benjhayden
Visibility:
Public.

Description

Fix utterly wrong comment that hasn't been true for years. BUG=none TEST=none; no code change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139128

Patch Set 1 #

Total comments: 1

Patch Set 2 : moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M content/public/browser/navigation_controller.h View 1 4 chunks +19 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Avi (use Gerrit)
I can't believe this comment was never fixed three years ago, and benjhayden was just ...
8 years, 7 months ago (2012-05-24 21:35:13 UTC) #1
Avi (use Gerrit)
On 2012/05/24 21:35:13, Avi wrote: > I can't believe this comment was never fixed three ...
8 years, 7 months ago (2012-05-24 21:35:22 UTC) #2
jochen (gone - plz use gerrit)
https://chromiumcodereview.appspot.com/10448014/diff/1/content/public/browser/navigation_controller.h File content/public/browser/navigation_controller.h (right): https://chromiumcodereview.appspot.com/10448014/diff/1/content/public/browser/navigation_controller.h#newcode58 content/public/browser/navigation_controller.h:58: // during set-up. is this true? I thought this ...
8 years, 7 months ago (2012-05-24 21:38:55 UTC) #3
Avi (use Gerrit)
You know what? Tomorrow I'm scrutinizing every last comment in that file.
8 years, 7 months ago (2012-05-25 02:16:01 UTC) #4
Avi (use Gerrit)
ptal
8 years, 7 months ago (2012-05-25 14:45:32 UTC) #5
jochen (gone - plz use gerrit)
lgtm!
8 years, 7 months ago (2012-05-25 20:06:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10448014/6001
8 years, 7 months ago (2012-05-25 20:19:35 UTC) #7
commit-bot: I haz the power
8 years, 7 months ago (2012-05-25 21:46:38 UTC) #8
Change committed as 139128

Powered by Google App Engine
This is Rietveld 408576698