Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: runtime/vm/intermediate_language.h

Issue 10447133: FlowGraphCompiler is not a visitor any longer. Start consolidating shared code between the x64 and … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language.h
===================================================================
--- runtime/vm/intermediate_language.h (revision 8180)
+++ runtime/vm/intermediate_language.h (working copy)
@@ -1602,6 +1602,8 @@
void AddCatchEntry(TargetEntryInstr* entry) { catch_entries_.Add(entry); }
+ virtual void EmitNativeCode(FlowGraphCompiler* compiler);
+
private:
TargetEntryInstr* normal_entry_;
GrowableArray<TargetEntryInstr*> catch_entries_;
@@ -1635,6 +1637,8 @@
successor_ = instr;
}
+ virtual void EmitNativeCode(FlowGraphCompiler* compiler);
+
private:
ZoneGrowableArray<BlockEntryInstr*> predecessors_;
Instruction* successor_;
@@ -1689,6 +1693,8 @@
return try_index_;
}
+ virtual void EmitNativeCode(FlowGraphCompiler* compiler);
+
private:
BlockEntryInstr* predecessor_;
Instruction* successor_;
@@ -1972,13 +1978,6 @@
#undef DECLARE_VISIT_INSTRUCTION
protected:
- // Map a block number in a forward iteration into the block number in the
- // corresponding reverse iteration. Used to obtain an index into
- // block_order for reverse iterations.
- intptr_t reverse_index(intptr_t index) const {
- return block_order_.length() - index - 1;
- }
-
const GrowableArray<BlockEntryInstr*>& block_order_;
private:

Powered by Google App Engine
This is Rietveld 408576698