Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: runtime/vm/intermediate_language.h

Issue 10447133: FlowGraphCompiler is not a visitor any longer. Start consolidating shared code between the x64 and … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
===================================================================
--- runtime/vm/intermediate_language.h (revision 8206)
+++ runtime/vm/intermediate_language.h (working copy)
@@ -1533,6 +1533,7 @@
virtual intptr_t PredecessorCount() const = 0;
virtual BlockEntryInstr* PredecessorAt(intptr_t index) const = 0;
virtual void AddPredecessor(BlockEntryInstr* predecessor) = 0;
+ virtual void PrepareEntry(FlowGraphCompiler* compiler) = 0;
intptr_t preorder_number() const { return preorder_number_; }
void set_preorder_number(intptr_t number) { preorder_number_ = number; }
@@ -1603,6 +1604,8 @@
void AddCatchEntry(TargetEntryInstr* entry) { catch_entries_.Add(entry); }
+ virtual void PrepareEntry(FlowGraphCompiler* compiler);
+
private:
TargetEntryInstr* normal_entry_;
GrowableArray<TargetEntryInstr*> catch_entries_;
@@ -1636,6 +1639,8 @@
successor_ = instr;
}
+ virtual void PrepareEntry(FlowGraphCompiler* compiler);
+
private:
ZoneGrowableArray<BlockEntryInstr*> predecessors_;
Instruction* successor_;
@@ -1690,6 +1695,8 @@
return try_index_;
}
+ virtual void PrepareEntry(FlowGraphCompiler* compiler);
+
private:
BlockEntryInstr* predecessor_;
Instruction* successor_;
@@ -1973,13 +1980,6 @@
#undef DECLARE_VISIT_INSTRUCTION
protected:
- // Map a block number in a forward iteration into the block number in the
- // corresponding reverse iteration. Used to obtain an index into
- // block_order for reverse iterations.
- intptr_t reverse_index(intptr_t index) const {
- return block_order_.length() - index - 1;
- }
-
const GrowableArray<BlockEntryInstr*>& block_order_;
private:
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698