Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 10447114: Prepare push to trunk. Now working on version 3.11.9. (Closed)

Created:
8 years, 6 months ago by Toon Verwaest
Modified:
8 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Prepare push to trunk. Now working on version 3.11.9. R=jkummerow@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11688

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M ChangeLog View 1 chunk +17 lines, -0 lines 1 comment Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Toon Verwaest
8 years, 6 months ago (2012-05-31 13:15:57 UTC) #1
Jakob Kummerow
8 years, 6 months ago (2012-05-31 13:18:43 UTC) #2
LGTM with nit.

https://chromiumcodereview.appspot.com/10447114/diff/1/ChangeLog
File ChangeLog (right):

https://chromiumcodereview.appspot.com/10447114/diff/1/ChangeLog#newcode7
ChangeLog:7: Fix missing write barrier in store field stub.
nit: past tense please. More below.

Powered by Google App Engine
This is Rietveld 408576698