Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: lib/dom/scripts/systemhtml.py

Issue 10447091: Cleanup NodeSelectors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/dom/scripts/systemnative.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/dom/scripts/systemhtml.py
diff --git a/lib/dom/scripts/systemhtml.py b/lib/dom/scripts/systemhtml.py
index e45e6e734861ac9ac05a606155d3fa0dfb3bca00..855b6b13d9b73edc1160e11d6c9d1dc387004e9e 100644
--- a/lib/dom/scripts/systemhtml.py
+++ b/lib/dom/scripts/systemhtml.py
@@ -22,7 +22,9 @@ _private_html_members = set([
'Document.getElementsByClassName',
'Document.getElementsByName',
'Document.getElementsByTagName',
+ 'Document.querySelector',
'Document.querySelectorAll',
+ 'DocumentFragment.querySelector',
'DocumentFragment.querySelectorAll',
'Element.childElementCount',
'Element.children',
@@ -43,6 +45,7 @@ _private_html_members = set([
'Element.offsetLeft',
'Element.offsetTop',
'Element.offsetWidth',
+ 'Element.querySelector',
'Element.querySelectorAll',
'Element.removeAttribute',
'Element.scrollHeight',
@@ -63,7 +66,6 @@ _private_html_members = set([
"Node.nodeType",
'Node.removeChild',
'Node.replaceChild',
- 'NodeSelector.querySelectorAll',
'Storage.length',
'Storage.clear',
'Storage.getItem',
@@ -77,9 +79,6 @@ _private_html_members = set([
# identical functionality but with cleaner names.
_html_library_renames = {
'Document.defaultView': 'window',
- 'DocumentFragment.querySelector': 'query',
- 'NodeSelector.querySelector': 'query',
- 'Element.querySelector': 'query',
'Element.webkitMatchesSelector' : 'matchesSelector',
'Element.scrollIntoViewIfNeeded': 'scrollIntoView',
'Node.cloneNode': 'clone',
@@ -257,7 +256,6 @@ _html_library_remove = set([
])
_html_library_custom = set([
- 'Document.querySelector',
'IFrameElement.get:contentWindow',
'Window.get:document',
'Window.get:top',
« no previous file with comments | « no previous file | lib/dom/scripts/systemnative.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698