Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: lib/html/dartium/html_dartium.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 10447091: Cleanup NodeSelectors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « lib/dom/templates/html/interface/interface_Element.darttemplate ('k') | lib/html/frog/html_frog.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/dartium/html_dartium.dart
diff --git a/lib/html/dartium/html_dartium.dart b/lib/html/dartium/html_dartium.dart
index fc6b91766205f566a2b91aa252b90afe2d6f69d2..3602fc056815f19c9b2349501d12d4adf22d1a09 100644
--- a/lib/html/dartium/html_dartium.dart
+++ b/lib/html/dartium/html_dartium.dart
@@ -6937,6 +6937,8 @@ class _DocumentFragmentImpl extends _NodeImpl implements DocumentFragment {
elements.addAll(copy);
}
+ _ElementImpl query(String selectors) => $dom_querySelector(selectors);
+
ElementList queryAll(String selectors) =>
new _FrozenElementList._wrap($dom_querySelectorAll(selectors));
@@ -7138,7 +7140,7 @@ class _DocumentFragmentImpl extends _NodeImpl implements DocumentFragment {
return _on;
}
- Element query(String selectors) {
+ Element $dom_querySelector(String selectors) {
return _querySelector(selectors);
}
@@ -7207,9 +7209,8 @@ class _DocumentEventsImpl extends _EventsImpl implements DocumentEvents {
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-class _DocumentImpl extends _NodeImpl
- implements Document
- {
+class _DocumentImpl extends _NodeImpl implements Document
+{
_DocumentEventsImpl get on() {
@@ -7400,6 +7401,10 @@ class _DocumentImpl extends _NodeImpl
String _queryCommandValue(command) native "Document_queryCommandValue_Callback";
+ Element $dom_querySelector(String selectors) {
+ return _querySelector(selectors);
+ }
+
Element _querySelector(selectors) native "Document_querySelector_Callback";
NodeList $dom_querySelectorAll(String selectors) {
@@ -7439,9 +7444,6 @@ class _DocumentImpl extends _NodeImpl
return $dom_querySelector(selectors);
}
-// TODO(jacobr): autogenerate this method.
- _ElementImpl $dom_querySelector(String selectors) native "Document_querySelector_Callback";
-
ElementList queryAll(String selectors) {
if (const RegExp("""^\\[name=["'][^'"]+['"]\\]\$""").hasMatch(selectors)) {
final mutableMatches = $dom_getElementsByName(
@@ -8250,6 +8252,8 @@ class _ElementImpl extends _NodeImpl implements Element {
ElementList get elements() => new _ChildrenElementList._wrap(this);
+ _ElementImpl query(String selectors) => $dom_querySelector(selectors);
+
ElementList queryAll(String selectors) =>
new _FrozenElementList._wrap($dom_querySelectorAll(selectors));
@@ -8392,7 +8396,7 @@ class _ElementImpl extends _NodeImpl implements Element {
bool _hasAttribute(name) native "Element_hasAttribute_Callback";
- Element query(String selectors) {
+ Element $dom_querySelector(String selectors) {
return _querySelector(selectors);
}
@@ -31047,7 +31051,7 @@ interface Document extends HtmlElement {
String queryCommandValue(String command);
/** @domName Document.querySelector */
- Element query(String selectors);
+ Element $dom_querySelector(String selectors);
/** @domName Document.querySelectorAll */
NodeList $dom_querySelectorAll(String selectors);
@@ -31185,7 +31189,7 @@ interface DocumentFragment extends Element default _DocumentFragmentFactoryProvi
ElementEvents get on();
/** @domName DocumentFragment.querySelector */
- Element query(String selectors);
+ Element $dom_querySelector(String selectors);
/** @domName DocumentFragment.querySelectorAll */
NodeList $dom_querySelectorAll(String selectors);
@@ -31308,12 +31312,6 @@ interface Element extends Node, NodeSelector default _ElementFactoryProvider {
void set attributes(Map<String, String> value);
/**
- * @domName querySelectorAll, getElementsByClassName, getElementsByTagName,
- * getElementsByTagNameNS
- */
- ElementList queryAll(String selectors);
-
- /**
* @domName childElementCount, firstElementChild, lastElementChild,
* children, Node.nodes.add
*/
@@ -31505,7 +31503,7 @@ interface Element extends Node, NodeSelector default _ElementFactoryProvider {
void insertAdjacentText(String where, String text);
/** @domName Element.querySelector */
- Element query(String selectors);
+ Element $dom_querySelector(String selectors);
/** @domName Element.querySelectorAll */
NodeList $dom_querySelectorAll(String selectors);
@@ -35403,10 +35401,10 @@ interface NodeSelector {
/** @domName NodeSelector.querySelector */
- Element query(String selectors);
+ Element querySelector(String selectors);
/** @domName NodeSelector.querySelectorAll */
- NodeList $dom_querySelectorAll(String selectors);
+ NodeList querySelectorAll(String selectors);
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
« no previous file with comments | « lib/dom/templates/html/interface/interface_Element.darttemplate ('k') | lib/html/frog/html_frog.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698