Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 10447078: Merge 118261 - [chromium] Turn ENABLE(OVERFLOW_SCROLLING) off for Chromium port (Closed)

Created:
8 years, 6 months ago by jamesr
Modified:
8 years, 6 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Visibility:
Public.

Description

Merge 118261 - [chromium] Turn ENABLE(OVERFLOW_SCROLLING) off for Chromium port https://bugs.webkit.org/show_bug.cgi?id=87177 Reviewed by Eric Seidel. Source/WebKit/chromium: Removes ENABLE(OVERFLOW_SCROLLING) from the set of enables set by Chromium. This guards a new non-standard CSS property, -webkit-overflow-scrolling, that was introduced by iOS5 intended for mobile browsers. This property is very partially implemented in Chromium but the way it's implemented does cause new stacking contexts to be created that otherwise would not be, breaking "desktop" pages. This turns the feature off until we can figure out how to deal with the compatibility issues. * features.gypi: LayoutTests: Mark test depending on ENABLE(OVERFLOW_SCROLLING) as an expected failure since the define is off. * platform/chromium/test_expectations.txt: TBR=jamesr@google.com BUG=124559 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118844

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+861 lines, -8403 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +628 lines, -8000 lines 0 comments Download
M LayoutTests/platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/platform/chromium/test_expectations.txt View 62 chunks +233 lines, -366 lines 0 comments Download
M Source/WebKit/chromium/features.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
jamesr
8 years, 6 months ago (2012-05-29 22:37:24 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698