Issue 10447066: views: Sort header files.

Issue 10447066: views: Sort header files. (Closed)

Created:
8 years, 6 months ago by tfarina

Modified:
8 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, James Su, ben+watch_chromium.org, penghuang+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Sort header files. This patch was generated by running: $ for f in $(find ui/views/ -type f $ -name "*.cc" -o -name "*.h" $); do ./tools/sort-headers.py $f; done R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139528

Patch Set 1 #

Total comments: 1

Patch Set 2 : rm duplicated include #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -28 lines)			Patch
M	ui/views/controls/button/text_button.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/combobox/native_combobox_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/focusable_border.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/label.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/menu/menu_config_views.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/views/controls/menu/menu_item_view_views.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/menu/menu_item_view_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/menu/menu_scroll_view_container.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/menu/menu_separator_views.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/menu/menu_separator_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/menu/native_menu_win.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/views/controls/tabbed_pane/native_tabbed_pane_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/table/table_view_win.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/views/controls/textfield/native_textfield_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/textfield/textfield_views_model.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/throbber.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/tree/tree_view_views.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/webview/webview.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/focus/focus_manager.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/view_model_utils.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/widget/desktop_native_widget_helper_aura.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	ui/views/widget/native_widget_win.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	ui/views/widget/widget_message_filter.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/window/dialog_client_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

8 years, 6 months ago (2012-05-29 16:32:17 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10447066/diff/1/ui/views/controls/tabl...
File ui/views/controls/table/table_view_win.cc (right):

https://chromiumcodereview.appspot.com/10447066/diff/1/ui/views/controls/tabl...
ui/views/controls/table/table_view_win.cc:26: #include
"ui/gfx/image/image_skia.h"
Remove this.

Expand Messages | Collapse Messages