webkit/fileapi/fileapi_export.h - Issue 10447055: Move fileapi into its own component

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webkit/fileapi/fileapi_export.h

Issue 10447055: Move fileapi into its own component (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixes and use FILEAPI_EXPORT_PRIVATE Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef WEBKIT_FILEAPI_FILEAPI_EXPORT_H_

	6 #define WEBKIT_FILEAPI_FILEAPI_EXPORT_H_

	7 #pragma once

	8

	9 #if defined(COMPONENT_BUILD)

	10 #if defined(WIN32)

	11

	12 #if defined(FILEAPI_IMPLEMENTATION)
	ericu 2012/05/29 17:59:49 What's the difference between FILEAPI_EXPORT and F What's the difference between FILEAPI_EXPORT and FILEAPI_EXPORT_PRIVATE? Unless I'm misreading this file, I don't see any in the definitions. If there's going to be a difference later, is there any automated way of catching it if we use the wrong one? benwells 2012/05/29 23:46:52 There is no difference. Apparently this is a docum Show quoted text On 2012/05/29 17:59:49, ericu wrote: > What's the difference between FILEAPI_EXPORT and FILEAPI_EXPORT_PRIVATE? Unless > I'm misreading this file, I don't see any in the definitions. If there's going > to be a difference later, is there any automated way of catching it if we use > the wrong one? There is no difference. Apparently this is a documentation kind of thing, which means there is no way of knowing if it is right or not which is less than desirable. This pattern is used elsewhere (e.g. BASE_EXPORT), I was told on irc it's the correct thing to do.
	13 #define FILEAPI_EXPORT __declspec(dllexport)

	14 #define FILEAPI_EXPORT_PRIVATE __declspec(dllexport)

	15 #else

	16 #define FILEAPI_EXPORT __declspec(dllimport)

	17 #define FILEAPI_EXPORT_PRIVATE __declspec(dllimport)

	18 #endif // defined(FILEAPI_IMPLEMENTATION)

	19

	20 #else // defined(WIN32)

	21 #if defined(FILEAPI_IMPLEMENTATION)

	22 #define FILEAPI_EXPORT __attribute__((visibility("default")))

	23 #define FILEAPI_EXPORT_PRIVATE __attribute__((visibility("default")))

	24 #else

	25 #define FILEAPI_EXPORT

	26 #define FILEAPI_EXPORT_PRIVATE

	27 #endif

	28 #endif

	29

	30 #else // defined(COMPONENT_BUILD)

	31 #define FILEAPI_EXPORT

	32 #define FILEAPI_EXPORT_PRIVATE

	33 #endif

	34

	35 #endif // WEBKIT_FILEAPI_FILEAPI_EXPORT_H_

OLD	NEW

« webkit/fileapi/file_system_url_request_job_factory.h ('K') | « webkit/fileapi/file_writer_delegate.h ('k') | webkit/fileapi/isolated_context.h » ('j') | webkit/glue/webkit_glue.cc » ('J')