Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 10447050: Add net, content and ipc to the default list of APK test bundles. (Closed)

Created:
8 years, 7 months ago by nilesh
Modified:
8 years, 6 months ago
Reviewers:
John Grabowski, Yaron
CC:
chromium-reviews
Visibility:
Public.

Description

Add net, content and ipc to the default list of APK test bundles. These APK bundles are compiled and run on the android_test try bot. Test run: http://build.chromium.org/p/tryserver.chromium/builders/android_test/builds/117 All tests pass. BUG=125059 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139497

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adding content and ipc test bundles too. #

Patch Set 3 : Add content and net apk bundles to all_android.gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M build/all_android.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M build/android/gtest_filter/base_unittests_disabled View 1 1 chunk +0 lines, -1 line 0 comments Download
M build/android/gtest_filter/content_unittests_disabled View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/android/run_tests.py View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nilesh
8 years, 7 months ago (2012-05-26 00:07:42 UTC) #1
Yaron
http://codereview.chromium.org/10447050/diff/1/build/android/run_tests.py File build/android/run_tests.py (right): http://codereview.chromium.org/10447050/diff/1/build/android/run_tests.py#newcode69 build/android/run_tests.py:69: _TEST_SUITES = ['base_unittests', So could you start removing base ...
8 years, 7 months ago (2012-05-26 00:40:09 UTC) #2
nilesh
http://codereview.chromium.org/10447050/diff/1/build/android/run_tests.py File build/android/run_tests.py (right): http://codereview.chromium.org/10447050/diff/1/build/android/run_tests.py#newcode69 build/android/run_tests.py:69: _TEST_SUITES = ['base_unittests', On 2012/05/26 00:40:10, Yaron wrote: > ...
8 years, 7 months ago (2012-05-26 00:49:08 UTC) #3
Yaron
lgtm
8 years, 7 months ago (2012-05-26 00:50:33 UTC) #4
John Grabowski
LGTM
8 years, 6 months ago (2012-05-29 17:44:35 UTC) #5
nilesh
On 2012/05/29 17:44:35, John Grabowski wrote: > LGTM John/Yaron, I have added to run ipc ...
8 years, 6 months ago (2012-05-30 01:28:16 UTC) #6
Yaron
lgtm
8 years, 6 months ago (2012-05-30 01:34:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10447050/4002
8 years, 6 months ago (2012-05-30 04:36:19 UTC) #8
commit-bot: I haz the power
8 years, 6 months ago (2012-05-30 08:13:06 UTC) #9
Change committed as 139497

Powered by Google App Engine
This is Rietveld 408576698