Move all webkit/fileapi tests to content_unittests

Move all webkit/fileapi tests to content_unittests

Most were previously in test_shell_tests, which we're trying to kill.
The rest were in unit_tests, and are being moved for consistency's sake.

BUG=126514
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140919

[adamk, 2012-05-25 21:26:01]

This change was suggested by Tony for an easy cleanup on a Friday afternoon.

Reviewers:

ericu for fileapi
tony for test_shell_tests.gypi
jam for content

[jochen (gone - plz use gerrit), 2012-05-25 21:33:21]

unofficial content lg

[tony, 2012-05-25 22:47:48]

lgtm

[jam, 2012-05-28 17:13:21]

lgtm

[kinuko, 2012-05-29 02:05:45]

So all of tests that were running as a part of unit_tests and test_shell_tests
are going to run as content_unittests?
lgtm

[ericu, 2012-05-30 23:54:09]

LGTM other than this.

https://chromiumcodereview.appspot.com/10447043/diff/1/webkit/fileapi/file_sy...
File webkit/fileapi/file_system_mount_point_provider_unittest.cc (right):

https://chromiumcodereview.appspot.com/10447043/diff/1/webkit/fileapi/file_sy...
webkit/fileapi/file_system_mount_point_provider_unittest.cc:257: MessageLoop
message_loop_;
I don't see this being used.  What am I missing?
[same in other files]

Is there some magic inside TEST_F?

[tony, 2012-05-31 00:25:22]

https://chromiumcodereview.appspot.com/10447043/diff/1/webkit/fileapi/file_sy...
File webkit/fileapi/file_system_mount_point_provider_unittest.cc (right):

https://chromiumcodereview.appspot.com/10447043/diff/1/webkit/fileapi/file_sy...
webkit/fileapi/file_system_mount_point_provider_unittest.cc:257: MessageLoop
message_loop_;
On 2012/05/30 23:54:09, ericu wrote:
> I don't see this being used.  What am I missing?
> [same in other files]

MessageLoopProxy::current() is null without it.  In test_shell_tests, we had a
current message loop associated with test_shell.

[ericu, 2012-05-31 01:46:47]

On Wed, May 30, 2012 at 5:25 PM,  <tony@chromium.org> wrote:
>
>
https://chromiumcodereview.appspot.com/10447043/diff/1/webkit/fileapi/file_sy...
> File webkit/fileapi/file_system_mount_point_provider_unittest.cc
> (right):
>
>
https://chromiumcodereview.appspot.com/10447043/diff/1/webkit/fileapi/file_sy...
> webkit/fileapi/file_system_mount_point_provider_unittest.cc:257:
> MessageLoop message_loop_;
> On 2012/05/30 23:54:09, ericu wrote:
>>
>> I don't see this being used.  What am I missing?
>> [same in other files]
>
>
> MessageLoopProxy::current() is null without it.  In test_shell_tests, we
> had a current message loop associated with test_shell.
>
> https://chromiumcodereview.appspot.com/10447043/

OK, magic it is ;'>.

[commit-bot: I haz the power, 2012-06-06 19:51:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adamk@chromium.org/10447043/14001

[commit-bot: I haz the power, 2012-06-06 20:14:54]

Try job failure for 10447043-14001 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-06-07 00:06:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adamk@chromium.org/10447043/15011

[commit-bot: I haz the power, 2012-06-07 01:20:11]

Change committed as 140919