Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 10447026: remove redundant includes of common.gypi and unused repo (support) (Closed)

Created:
8 years, 7 months ago by scottmg
Modified:
8 years, 6 months ago
CC:
chromium-reviews, grt+watch_chromium.org, amit, abodenha, MAD
Visibility:
Public.

Description

Remove redundant includes of common.gypi and unused repo from DEPS build/gyp_chromium forces include of build/common.gypi for all gyp files so including it in other .gyp files is redundant. In the case of some properties, it causes duplication in lists which causes problems. One of these was in build/util/support/support.gyp which is still getting synced, but apparently has been long deleted and removed (2011). But the DEPS were never rolled to remove the whole repo the last unused file got removed here http://codereview.chromium.org/6294009 apparently. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139259 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139268

Patch Set 1 #

Patch Set 2 : remove outdated reference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M DEPS View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/chrome_installer.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/crash_reporting/crash_reporting.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/virtual_driver_port_monitor.gyp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scottmg
(fyi, chrome_frame & cloud_print in case there's some odd chance this could cause a problem)
8 years, 7 months ago (2012-05-24 23:40:54 UTC) #1
robertshield
On 2012/05/24 23:40:54, scottmg wrote: > (fyi, chrome_frame & cloud_print in case there's some odd ...
8 years, 7 months ago (2012-05-24 23:54:06 UTC) #2
Ryan Sleevi
Syntactically LGTM, but please run it through trybots /and/ reach out to OWNERS in those ...
8 years, 7 months ago (2012-05-25 00:00:35 UTC) #3
Albert Bodenhamer
LGTM Please make sure you run WINDOWS trybots before you land this since the virtual ...
8 years, 7 months ago (2012-05-25 00:14:22 UTC) #4
scottmg
(missed one gyp reference)
8 years, 6 months ago (2012-05-28 21:08:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10447026/11001
8 years, 6 months ago (2012-05-28 21:14:47 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-05-28 23:30:23 UTC) #7
Change committed as 139268

Powered by Google App Engine
This is Rietveld 408576698