Add pylint to depot_tools.

Add pylint to depot_tools.

This CL adds pylint (and its dependencies) to third_party. It plumbs them into presubmit_canned_checks, and exposes a command-line tool to access pylint.

BUG=
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143016

[chrisha, 2012-05-24 14:13:28]

PTAL.

[chrisha, 2012-06-08 16:58:42]

PTAL.

[M-A Ruel, 2012-06-08 18:02:36]

lgtm with nti

https://chromiumcodereview.appspot.com/10447014/diff/15019/bootstrap/win/pyli...
File bootstrap/win/pylint.new.bat (right):

https://chromiumcodereview.appspot.com/10447014/diff/15019/bootstrap/win/pyli...
bootstrap/win/pylint.new.bat:4: "%~dp0python_bin\python.exe" "%~dp0pylint.py" %*
I'd prefer:
call python "%~dp0pylint.py" %*

and proper copyright header.

The reason is that for example do not use depot_tools' python.

[M-A Ruel, 2012-06-18 12:55:07]

Ping.

[chrisha, 2012-06-18 13:09:28]

Oops! I'll get on it this morning!

On Mon, Jun 18, 2012 at 8:55 AM,  <maruel@chromium.org> wrote:
> Ping.
>
> https://chromiumcodereview.appspot.com/10447014/

[chrisha, 2012-06-18 21:06:58]

Having a hard time uploading this (with fixed unittest) due to flaky internet in
the Montreal office (fibre cable was cut, apparently). Will try again in the
morning.

https://chromiumcodereview.appspot.com/10447014/diff/15019/bootstrap/win/pyli...
File bootstrap/win/pylint.new.bat (right):

https://chromiumcodereview.appspot.com/10447014/diff/15019/bootstrap/win/pyli...
bootstrap/win/pylint.new.bat:4: "%~dp0python_bin\python.exe" "%~dp0pylint.py" %*
On 2012/06/08 18:02:36, Marc-Antoine Ruel wrote:
> I'd prefer:
> call python "%~dp0pylint.py" %*
> 
> and proper copyright header.
> 
> The reason is that for example do not use depot_tools' python.

Done.

(I had simply copied python.bat as a template, maybe update copyright headers
there as well in a follow-up CL?)

[M-A Ruel, 2012-06-19 01:23:28]

On 2012/06/18 21:06:58, chrisha wrote:
> (I had simply copied python.bat as a template, maybe update copyright headers
> there as well in a follow-up CL?)

I don't mind, lgtm. :)

[chrisha, 2012-06-19 14:52:06]

Thanks, committing.

[commit-bot: I haz the power, 2012-06-19 14:52:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrisha@chromium.org/10447014/41017

[commit-bot: I haz the power, 2012-06-19 14:55:09]

Presubmit check for 10447014-41017 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...

** Presubmit ERRORS **
tests/checkout_test.py failed!
Command tests/checkout_test.py returned non-zero exit status 1 in
/b/commit-queue/workdir/tools/depot_tools
EEEEEEE...................
======================================================================
ERROR: testAll (__main__.GitSvnCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 447, in testAll
    self._check_base(self._get_co(None), root, True, expected)
  File "tests/checkout_test.py", line 154, in _check_base
    self.assertEquals(self.previous_log['revision'], co.prepare(None))
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 742, in
prepare
    stderr=subprocess2.STDOUT)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 659, in
_check_call_git_svn
    return self._check_call_git(args, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 544, in
_check_call_git
    return subprocess2.check_call_out(['git'] + args, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/subprocess2.py", line 412, in
check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git svn clone --prefix origin/ -T trunk
svn://127.0.0.1:10000/svn/
/tmp/trialh0hfrK/__main__.GitSvnCheckout.testAll/foo.git --quiet returned
non-zero exit status 1 in /tmp/trialh0hfrK/__main__.GitSvnCheckout.testAll

======================================================================
ERROR: testException (__main__.GitSvnCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 465, in testException
    self._get_co(None), 'fatal: corrupt patch at line 12\n')
  File "tests/checkout_test.py", line 196, in _check_exception
    co.prepare(None)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 742, in
prepare
    stderr=subprocess2.STDOUT)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 659, in
_check_call_git_svn
    return self._check_call_git(args, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 544, in
_check_call_git
    return subprocess2.check_call_out(['git'] + args, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/subprocess2.py", line 412, in
check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git svn clone --prefix origin/ -T trunk
svn://127.0.0.1:10000/svn/
/tmp/trialh0hfrK/__main__.GitSvnCheckout.testException/foo.git --quiet returned
non-zero exit status 1 in /tmp/trialh0hfrK/__main__.GitSvnCheckout.testException

======================================================================
ERROR: testGitSvnPremade (__main__.GitSvnCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 452, in testGitSvnPremade
    revision = git_svn_co.prepare(None)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 742, in
prepare
    stderr=subprocess2.STDOUT)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 659, in
_check_call_git_svn
    return self._check_call_git(args, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 544, in
_check_call_git
    return subprocess2.check_call_out(['git'] + args, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/subprocess2.py", line 412, in
check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git svn clone --prefix origin/ -T trunk
svn://127.0.0.1:10000/svn/
/tmp/trialh0hfrK/__main__.GitSvnCheckout.testGitSvnPremade/foo.git --quiet
returned non-zero exit status 1 in
/tmp/trialh0hfrK/__main__.GitSvnCheckout.testGitSvnPremade

======================================================================
ERROR: testMove (__main__.GitSvnCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 502, in testMove
    self._check_move(self._get_co(None))
  File "tests/checkout_test.py", line 224, in _check_move
    co.prepare(None)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 742, in
prepare
    stderr=subprocess2.STDOUT)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 659, in
_check_call_git_svn
    return self._check_call_git(args, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 544, in
_check_call_git
    return subprocess2.check_call_out(['git'] + args, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/subprocess2.py", line 412, in
check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git svn clone --prefix origin/ -T trunk
svn://127.0.0.1:10000/svn/
/tmp/trialh0hfrK/__main__.GitSvnCheckout.testMove/foo.git --quiet returned
non-zero exit status 1 in /tmp/trialh0hfrK/__main__.GitSvnCheckout.testMove

======================================================================
ERROR: testPrepare (__main__.GitSvnCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 499, in testPrepare
    self._test_prepare(co)
  File "tests/checkout_test.py", line 289, in _test_prepare
    self.assertEquals(1, co.prepare(1))
  File "tests/checkout_test.py", line 496, in prepare
    self.assertEquals(2, co.old_prepare(None))
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 742, in
prepare
    stderr=subprocess2.STDOUT)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 659, in
_check_call_git_svn
    return self._check_call_git(args, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 544, in
_check_call_git
    return subprocess2.check_call_out(['git'] + args, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/subprocess2.py", line 412, in
check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git svn clone --prefix origin/ -T trunk
svn://127.0.0.1:10000/svn/
/tmp/trialh0hfrK/__main__.GitSvnCheckout.testPrepare/foo.git --quiet returned
non-zero exit status 1 in /tmp/trialh0hfrK/__main__.GitSvnCheckout.testPrepare

======================================================================
ERROR: testProcess (__main__.GitSvnCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 487, in testProcess
    self._test_process(self._get_co)
  File "tests/checkout_test.py", line 212, in _test_process
    co.prepare(None)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 742, in
prepare
    stderr=subprocess2.STDOUT)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 659, in
_check_call_git_svn
    return self._check_call_git(args, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 544, in
_check_call_git
    return subprocess2.check_call_out(['git'] + args, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/subprocess2.py", line 412, in
check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git svn clone --prefix origin/ -T trunk
svn://127.0.0.1:10000/svn/
/tmp/trialh0hfrK/__main__.GitSvnCheckout.testProcess/foo.git --quiet returned
non-zero exit status 1 in /tmp/trialh0hfrK/__main__.GitSvnCheckout.testProcess

======================================================================
ERROR: testSvnProps (__main__.GitSvnCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 469, in testSvnProps
    co.prepare(None)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 742, in
prepare
    stderr=subprocess2.STDOUT)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 659, in
_check_call_git_svn
    return self._check_call_git(args, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 544, in
_check_call_git
    return subprocess2.check_call_out(['git'] + args, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/subprocess2.py", line 412, in
check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git svn clone --prefix origin/ -T trunk
svn://127.0.0.1:10000/svn/
/tmp/trialh0hfrK/__main__.GitSvnCheckout.testSvnProps/foo.git --quiet returned
non-zero exit status 1 in /tmp/trialh0hfrK/__main__.GitSvnCheckout.testSvnProps

----------------------------------------------------------------------
Ran 26 tests in 9.426s

FAILED (errors=7)


tests/scm_unittest.py failed!
Command tests/scm_unittest.py returned non-zero exit status 1 in
/b/commit-queue/workdir/tools/depot_tools
...EE...........
======================================================================
ERROR: testGetGetSha1ForSvnRev (__main__.RealGitSvnTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/scm_unittest.py", line 149, in setUp
    self._capture(['svn', 'clone', '-q', '-q', self.svn_url, self.clone_dir])
  File "tests/scm_unittest.py", line 161, in _capture
    return scm.GIT.Capture(cmd, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/scm.py", line 102, in Capture
    ['git'] + args, cwd=cwd, stderr=subprocess2.PIPE, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/subprocess2.py", line 449, in
check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File "/b/commit-queue/workdir/tools/d…
(message too large)

[commit-bot: I haz the power, 2012-06-19 14:57:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrisha@chromium.org/10447014/41017

[commit-bot: I haz the power, 2012-06-19 15:00:28]

Presubmit check for 10447014-41017 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...

** Presubmit ERRORS **
tests/checkout_test.py failed!
Command tests/checkout_test.py returned non-zero exit status 1 in
/b/commit-queue/workdir/tools/depot_tools

*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident  <chrome-bot@cq.golo.chromium.org
> not allowed
E..
*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident  <chrome-bot@cq.golo.chromium.org
> not allowed
E.
*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident  <chrome-bot@cq.golo.chromium.org
> not allowed
E
*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident  <chrome-bot@cq.golo.chromium.org
> not allowed
E...................
======================================================================
ERROR: testAll (__main__.GitSvnCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 447, in testAll
    self._check_base(self._get_co(None), root, True, expected)
  File "tests/checkout_test.py", line 158, in _check_base
    co.apply_patch(patches)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 525, in
apply_patch
    self._check_call_git(['commit', '-m', 'Committed patch'])
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 544, in
_check_call_git
    return subprocess2.check_call_out(['git'] + args, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/subprocess2.py", line 412, in
check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git commit -m Committed patch returned non-zero exit
status 128 in /tmp/trialtP1eOK/__main__.GitSvnCheckout.testAll/foo.git

======================================================================
ERROR: testMove (__main__.GitSvnCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 502, in testMove
    self._check_move(self._get_co(None))
  File "tests/checkout_test.py", line 230, in _check_move
    co.apply_patch(patchset)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 525, in
apply_patch
    self._check_call_git(['commit', '-m', 'Committed patch'])
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 544, in
_check_call_git
    return subprocess2.check_call_out(['git'] + args, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/subprocess2.py", line 412, in
check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git commit -m Committed patch returned non-zero exit
status 128 in /tmp/trialtP1eOK/__main__.GitSvnCheckout.testMove/foo.git

======================================================================
ERROR: testProcess (__main__.GitSvnCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 487, in testProcess
    self._test_process(self._get_co)
  File "tests/checkout_test.py", line 215, in _test_process
    co.apply_patch(ps)
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 525, in
apply_patch
    self._check_call_git(['commit', '-m', 'Committed patch'])
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 544, in
_check_call_git
    return subprocess2.check_call_out(['git'] + args, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/subprocess2.py", line 412, in
check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git commit -m Committed patch returned non-zero exit
status 128 in /tmp/trialtP1eOK/__main__.GitSvnCheckout.testProcess/foo.git

======================================================================
ERROR: testSvnProps (__main__.GitSvnCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 484, in testSvnProps
    [patch.FilePatchDiff('chrome/file.cc', RAW.PATCH, svn_props)])
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 525, in
apply_patch
    self._check_call_git(['commit', '-m', 'Committed patch'])
  File "/b/commit-queue/workdir/tools/depot_tools/checkout.py", line 544, in
_check_call_git
    return subprocess2.check_call_out(['git'] + args, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/subprocess2.py", line 412, in
check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git commit -m Committed patch returned non-zero exit
status 128 in /tmp/trialtP1eOK/__main__.GitSvnCheckout.testSvnProps/foo.git

----------------------------------------------------------------------
Ran 26 tests in 23.724s

FAILED (errors=4)


tests/scm_unittest.py failed!
Command tests/scm_unittest.py returned non-zero exit status 1 in
/b/commit-queue/workdir/tools/depot_tools
...
*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident  <chrome-bot@cq.golo.chromium.org
> not allowed
E.E..........
======================================================================
ERROR: testGetGetSha1ForSvnRev (__main__.RealGitSvnTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/scm_unittest.py", line 142, in setUp
    self.enabled = self.FAKE_REPOS.set_up_git() and self.FAKE_REPOS.set_up_svn()
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
381, in set_up_git
    self.populateGit()
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
560, in populateGit
    'origin': 'git/repo_3@1\n',
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
398, in _commit_git
    commit_hash = commit_git(repo_root)
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
95, in commit_git
    subprocess2.check_call(['git', 'commit', '-q', '--message', 'foo'],
cwd=repo)
  File "/b/commit-queue/workdir/tools/depot_tools/subprocess2.py", line 418, in
check_call
    check_call_out(args, **kwargs)
  File "/b/commit-queue/workdir/tools/depot_tools/subprocess2.py", line 412, in
check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git commit -q --message foo returned non-zero exit
status 128 in /tmp/trial8GHeLx/repos/git/repo_3

======================================================================
ERROR: testIsValidRevision (__main__.RealGitTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/scm_unittest.py", line 134, in testIsValidRevision
    first_rev = self.githash('repo_1', 1)
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
731, in githash
    return self.FAKE_REPOS.git_hashes[repo][int(rev)][0]
IndexError: list index out of range

----------------------------------------------------------------------
Ran 16 tests in 16.211s

FAILED (errors=2)


tests/presubmit_unittest.py failed!
Command tests/presubmit_unittest.py returned non-zero exit status 1 in
/b/commit-queue/workdir/tools/depot_tools
Traceback (most recent call last):
  File "tests/presubmit_unittest.py", line 17, in <module>
    from pylint import lint  # pylint: disable=E0611
ImportError: No module named pylint


tests/gclient_smoketest.py failed!
Command tests/gclient_smoketest.py returned non-zero exit status 1 in
/b/commit-queue/workdir/tools/depot_tools
......
*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident  <chrome-bot@cq.golo.chromium.org
> not allowed
EFEEE.....EEEFEFE.................
======================================================================
ERROR: testMultiSolutions (__main__.GClientSmokeBoth)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1021, in setUp
    self.enabled = self.FAKE_REPOS.set_up_svn() and self.FAKE_REPOS.set_up_git()
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
381, in set_up_git
    self.populateGit()
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
560, in populateGit
    'origin': 'git/repo_3@1\n',
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
398, in _commit_git
    commit_hash = commit_git(repo_root)
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
95, in commit_git
    subprocess2.check_call(['git', 'commit', '-q', '--message', 'foo'],
cwd=repo)
  File "/b/commit-queue/w…
(message too large)

[commit-bot: I haz the power, 2012-06-19 15:04:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrisha@chromium.org/10447014/41017

[commit-bot: I haz the power, 2012-06-19 15:07:09]

Presubmit check for 10447014-41017 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...

** Presubmit ERRORS **
tests/presubmit_unittest.py failed!
Command tests/presubmit_unittest.py returned non-zero exit status 1 in
/b/commit-queue/workdir/tools/depot_tools
Traceback (most recent call last):
  File "tests/presubmit_unittest.py", line 17, in <module>
    from pylint import lint  # pylint: disable=E0611
ImportError: No module named pylint


tests/gclient_scm_test.py failed!
Command tests/gclient_scm_test.py returned non-zero exit status 1 in
/b/commit-queue/workdir/tools/depot_tools
.FEFEFEF...FE.FFERROR:root:Error during fast-forward merge in .!
.F............................
======================================================================
ERROR: testRevertMissing (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 770, in tearDown
    StdoutCheck.tearDown(self)
  File "/b/commit-queue/workdir/tools/depot_tools/testing_support/super_mox.py",
line 101, in tearDown
    self.assertEquals('', sys.stdout.getvalue())
AssertionError: '' != "\n_____ . at refs/heads/master\nUpdating
069c602..a7142dc\nFast-forward\n a |    1 +\n b |    1 +\n 2 files changed, 2
insertions(+)\n\n\n________ running 'git reset --hard origin/master' in
'/tmp/tmpiy89s5/.'\nHEAD is now at a7142dc Personalized\n\n________ running 'git
diff a7142dc9f0009350b96a11f372b6ea658592aa95' in '/tmp/tmpiy89s5/.'\n"

======================================================================
ERROR: testRevertModified (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 770, in tearDown
    StdoutCheck.tearDown(self)
  File "/b/commit-queue/workdir/tools/depot_tools/testing_support/super_mox.py",
line 101, in tearDown
    self.assertEquals('', sys.stdout.getvalue())
AssertionError: '' != "\n_____ . at refs/heads/master\nUpdating
069c602..a7142dc\nFast-forward\n a |    1 +\n b |    1 +\n 2 files changed, 2
insertions(+)\n\n\n________ running 'git reset --hard origin/master' in
'/tmp/tmpFfntx4/.'\nHEAD is now at a7142dc Personalized\n\n________ running 'git
diff a7142dc9f0009350b96a11f372b6ea658592aa95' in '/tmp/tmpFfntx4/.'\n"

======================================================================
ERROR: testRevertNew (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 770, in tearDown
    StdoutCheck.tearDown(self)
  File "/b/commit-queue/workdir/tools/depot_tools/testing_support/super_mox.py",
line 101, in tearDown
    self.assertEquals('', sys.stdout.getvalue())
AssertionError: '' != "\n_____ . at refs/heads/master\nUpdating
069c602..a7142dc\nFast-forward\n a |    1 +\n b |    1 +\n 2 files changed, 2
insertions(+)\n\n\n________ running 'git reset --hard origin/master' in
'/tmp/tmp2NV0CB/.'\nHEAD is now at a7142dc Personalized\n\n________ running 'git
diff a7142dc9f0009350b96a11f372b6ea658592aa95' in '/tmp/tmp2NV0CB/.'\n"

======================================================================
ERROR: testUpdateConflict (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 770, in tearDown
    StdoutCheck.tearDown(self)
  File "/b/commit-queue/workdir/tools/depot_tools/testing_support/super_mox.py",
line 101, in tearDown
    self.assertEquals('', sys.stdout.getvalue())
AssertionError: '' != "\n________ running 'git commit -am test' in
'/tmp/tmpVtGYce/.'\n[new ac271e6] test\n 1 file changed, 1 insertion(+), 1
deletion(-)\n\n_____ . at refs/heads/master\nAttempting rebase onto
refs/remotes/origin/master...\n"

======================================================================
FAIL: testRevertMissing (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 822, in testRevertMissing
    self.assertTrue(sys.stdout.getvalue().startswith(expectation))
AssertionError

======================================================================
FAIL: testRevertModified (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 869, in testRevertModified
    self.assertTrue(sys.stdout.getvalue().startswith(expectation))
AssertionError

======================================================================
FAIL: testRevertNew (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 899, in testRevertNew
    self.assertTrue(sys.stdout.getvalue().startswith(expectation))
AssertionError

======================================================================
FAIL: testRevertNone (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 844, in testRevertNone
    join(self.root_dir, '.'))
  File "/b/commit-queue/workdir/tools/depot_tools/testing_support/super_mox.py",
line 110, in checkstdout
    self.assertEquals(expected, value)
AssertionError: "\n_____ . at refs/heads/master\nUpdating
069c602..a7142dc\nFast-forward\n a |    1 +\n b |    1 +\n 2 files changed, 2
insertions(+), 0 deletions(-)\n\n\n________ running 'git reset --hard
origin/master' in '/tmp/tmpT8kfrn/.'\nHEAD is now at a7142dc Personalized\n" !=
"\n_____ . at refs/heads/master\nUpdating 069c602..a7142dc\nFast-forward\n a |  
 1 +\n b |    1 +\n 2 files changed, 2 insertions(+)\n\n\n________ running 'git
reset --hard origin/master' in '/tmp/tmpT8kfrn/.'\nHEAD is now at a7142dc
Personalized\n"

======================================================================
FAIL: testUpdateConflict (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 1056, in testUpdateConflict
    self.assertTrue(sys.stdout.getvalue().endswith(end))
AssertionError

======================================================================
FAIL: testUpdateReset (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 980, in testUpdateReset
    % join(self.root_dir, '.'))
  File "/b/commit-queue/workdir/tools/depot_tools/testing_support/super_mox.py",
line 110, in checkstdout
    self.assertEquals(expected, value)
AssertionError: "\n________ running 'git reset --hard HEAD' in
'/tmp/tmpVEH_1G/.'\nHEAD is now at 069c602 A and B\n\n_____ . at
refs/heads/master\nUpdating 069c602..a7142dc\nFast-forward\n a |    1 +\n b |   
1 +\n 2 files changed, 2 insertions(+), 0 deletions(-)\n\n" != "\n________
running 'git reset --hard HEAD' in '/tmp/tmpVEH_1G/.'\nHEAD is now at 069c602 A
and B\n\n_____ . at refs/heads/master\nUpdating 069c602..a7142dc\nFast-forward\n
a |    1 +\n b |    1 +\n 2 files changed, 2 insertions(+)\n\n"

======================================================================
FAIL: testUpdateResetDeleteUnversionedTrees (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 1009, in
testUpdateResetDeleteUnversionedTrees
    '.'))
  File "/b/commit-queue/workdir/tools/depot_tools/testing_support/super_mox.py",
line 110, in checkstdout
    self.assertEquals(expected, value)
AssertionError: "\n________ running 'git reset --hard HEAD' in
'/tmp/tmp3kOitf/.'\nHEAD is now at 069c602 A and B\n\n_____ . at
refs/heads/master\nUpdating 069c602..a7142dc\nFast-forward\n a |    1 +\n b |   
1 +\n 2 files changed, 2 insertions(+), 0 deletions(-)\n\n\n_____ removing
unversioned directory dir/\n" != "\n________ running 'git reset --hard HEAD' in
'/tmp/tmp3kOitf/.'\nHEAD is now at 069c602 A and B\n\n_____ . at
refs/heads/master\nUpdating 069c602..a7142dc\nFast-forward\n a |    1 +\n b |   
1 +\n 2 files changed, 2 insertions(+)\n\n\n_____ removing unversioned directory
dir/\n"

======================================================================
FAIL: testUpdateUpdate (__main__.ManagedGitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 951, in testUpdateUpdate
    '\n_____ . at refs/heads/master\n'
  File "/b/commit-queue/workdir/tools/depot_tools/testing_support/super_mox.py",
line 110, in checkstdout
    self.assertEquals(expected, value)
AssertionError: '\n_____ . at refs/heads/master\nUpdating
069c602..a7142dc\nFast-forward\n a |    1 +\n b |    1 +\n 2 files changed, 2
insertions(+), 0 deletions(-)\n\n' != '\n_____ . at refs/heads/master\nUpdating
069c602..a7142dc\nFast-forward\n a |    1 +\n b |    1 +\n 2 files changed, 2
insertions(+)\n\n'

----------------------------------------------------------------------
Ran 42 tests in 1.659s

FAILED (failures=8, errors=4)


Failed to checkout rietveld. Do you have mercurial installed?
[Errno 2] No such file or directory

Presubmit checks took 134.3s to calculate.

[M-A Ruel, 2012-06-19 15:08:05]

On 2012/06/19 15:07:09, I haz the power (commit-bot) wrote:
> Presubmit check for 10447014-41017 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> Checking out rietveld...
> 
> ** Presubmit ERRORS **
> tests/presubmit_unittest.py failed!
> Command tests/presubmit_unittest.py returned non-zero exit status 1 in
> /b/commit-queue/workdir/tools/depot_tools
> Traceback (most recent call last):
>   File "tests/presubmit_unittest.py", line 17, in <module>
>     from pylint import lint  # pylint: disable=E0611
> ImportError: No module named pylint

This should be fixed.

The remaining errors seems to be due to the newer version of git and can be
ignored.

[chrisha, 2012-06-19 19:22:35]

Manually committing for now.

[Peter Mayo, 2012-06-19 22:11:59]

On 2012/06/19 19:22:35, chrisha wrote:
> Manually committing for now.

This seems to be behind blow-up for me:

Running presubmit upload checks ...
/usr/local/lib/python2.6/dist-packages/logilab_common-0.55.2-py2.6.egg/logilab/__init__.py:3:
UserWarning: Module pylint was already imported from
/usr/local/google/home/petermayo/depot_tools/third_party/pylint/__init__.py, but
/usr/local/lib/python2.6/dist-packages/pylint-0.24.0-py2.6.egg is being added to
sys.path
  __import__('pkg_resources').declare_namespace(__name__)
************* Module master_chromiumos_cfg
F0401:  5,0: Unable to import 'master'
F0401:  6,0: Unable to import 'master.factory'


Is there a know work-around or PathFix?

[M-A Ruel, 2012-06-19 23:08:00]

On 2012/06/19 22:11:59, Peter Mayo wrote:
> On 2012/06/19 19:22:35, chrisha wrote:
> > Manually committing for now.
> 
> This seems to be behind blow-up for me:
> 
> Running presubmit upload checks ...
>
/usr/local/lib/python2.6/dist-packages/logilab_common-0.55.2-py2.6.egg/logilab/__init__.py:3:
> UserWarning: Module pylint was already imported from
> /usr/local/google/home/petermayo/depot_tools/third_party/pylint/__init__.py,
but
> /usr/local/lib/python2.6/dist-packages/pylint-0.24.0-py2.6.egg is being added
to
> sys.path
>   __import__('pkg_resources').declare_namespace(__name__)
> ************* Module master_chromiumos_cfg
> F0401:  5,0: Unable to import 'master'
> F0401:  6,0: Unable to import 'master.factory'
> 
> 
> Is there a know work-around or PathFix?

I've reproduced. Looking.

[scottmg, 2012-06-21 20:58:37]

I'm getting "The command line is too long." errors when trying to dcommit in gyp
now on Windows, and can't commit, I believe since this change.

I didn't trace through yet, but maybe it ends up using the shell instead of
calling python directly now? (so the limit is much lower)

[chrisha, 2012-06-21 21:02:07]

Urk... that's ugly. Due to licensing issues it was suggested that we
break out to pylint via the command-line rather than to load it
directly as a module. I definitely didn't think about the 'command
line too long' aspect as I did most my testing with small codebases.

I'll take a look tomorrow morning (just on my way out the door), but
we should be able to get around this by writing a new pylint wrapper
that can read the file list from stdin, and pipe the list to the child
process.

Other ideas?

Chris

On Thu, Jun 21, 2012 at 4:58 PM,  <scottmg@chromium.org> wrote:
> I'm getting "The command line is too long." errors when trying to dcommit in
> gyp
> now on Windows, and can't commit, I believe since this change.
>
> I didn't trace through yet, but maybe it ends up using the shell instead of
> calling python directly now? (so the limit is much lower)
>
> https://chromiumcodereview.appspot.com/10447014/

[scottmg, 2012-06-21 21:04:01]

On 2012/06/21 20:58:37, scottmg wrote:
> I'm getting "The command line is too long." errors when trying to dcommit in
gyp
> now on Windows, and can't commit, I believe since this change.
> 
> I didn't trace through yet, but maybe it ends up using the shell instead of
> calling python directly now? (so the limit is much lower)

Yeah, it looks like subprocess2 hacks shell=True to be the default on Windows
for questionable reasons. I don't know what will break if we turn that off
though.

I don't know pylint, is there a input/response file or something we can use
instead?

[scottmg, 2012-06-21 21:25:48]

On 2012/06/21 21:02:07, chrisha wrote:
> Urk... that's ugly. Due to licensing issues it was suggested that we
> break out to pylint via the command-line rather than to load it
> directly as a module. I definitely didn't think about the 'command
> line too long' aspect as I did most my testing with small codebases.
> 
> I'll take a look tomorrow morning (just on my way out the door), but
> we should be able to get around this by writing a new pylint wrapper
> that can read the file list from stdin, and pipe the list to the child
> process.
> 
> Other ideas?

That sounds fine to me. I tried to find docs for the rc file but didn't come up
with much. Putting the list of files/modules/whatever in there might be easier
if it's possible.

[chrisha, 2012-06-22 17:27:19]

Should be fixed as of
http://src.chromium.org/viewvc/chrome?view=rev&revision=143620

Let me know if you have any more troubles.

Chris

On Thu, Jun 21, 2012 at 5:25 PM,  <scottmg@chromium.org> wrote:
> On 2012/06/21 21:02:07, chrisha wrote:
>>
>> Urk... that's ugly. Due to licensing issues it was suggested that we
>> break out to pylint via the command-line rather than to load it
>> directly as a module. I definitely didn't think about the 'command
>> line too long' aspect as I did most my testing with small codebases.
>
>
>> I'll take a look tomorrow morning (just on my way out the door), but
>> we should be able to get around this by writing a new pylint wrapper
>> that can read the file list from stdin, and pipe the list to the child
>> process.
>
>
>> Other ideas?
>
>
> That sounds fine to me. I tried to find docs for the rc file but didn't come
> up
> with much. Putting the list of files/modules/whatever in there might be
> easier
> if it's possible.
>
> https://chromiumcodereview.appspot.com/10447014/