Add flow graph printing into a .cfg file with flag --print-flow-graph-file.

bin/main.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <stdlib.h>
 #include <string.h>
 #include <stdio.h>
 
 #include "include/dart_api.h"
 #include "include/dart_debugger_api.h"
@@ skipping 21 matching lines @@
 // Global state that stores the import URL map specified on the
 // command line.
 static CommandLineOptions* import_map_options = NULL;
 
 
 // Global state that indicates whether pprof symbol information is
 // to be generated or not.
 static const char* generate_pprof_symbols_filename = NULL;
 
 
+// Global state that stores a file name for flow graph debugging output.
+// NULL if no output is generated.
+static File* flow_graph_file = NULL;
+
 // Global state that indicates whether there is a debug breakpoint.
 // This pointer points into an argv buffer and does not need to be
 // free'd.
 static const char* breakpoint_at = NULL;
 
 
 // Global state that indicates whether we should open a connection
 // and listen for a debugger to connect.
 static bool start_debugger = false;
 static const int DEFAULT_DEBUG_PORT = 5858;
@@ skipping 70 matching lines @@
   start_debugger = true;
 }
 
 
 static void ProcessPprofOption(const char* filename) {
   ASSERT(filename != NULL);
   generate_pprof_symbols_filename = filename;
 }
 
 
+static void ProcessFlowGraphOption(const char* flowgraph_option) {
+  ASSERT(flowgraph_option != NULL);
+  flow_graph_file = File::Open("flowgraph.cfg", File::kWriteTruncate);
+  ASSERT(flow_graph_file != NULL);

[siva, 2012/06/04 18:23:57]

Where is flow_graph_file closed?

[Florian Schneider, 2012/06/06 11:06:10]

At process exit.  I could close it explicitly right before every possible exit
of main() which is currently in four different places.  Since it is only opened
when the --generate-flow-graph flag is on, I prefer not explicitly closing it
for conciseness.

[siva, 2012/06/06 17:02:47]

I disagree, correctness not conciseness is the yardstick to use. If a file is
opened it needs to be closed properly. You cannot rely on process exit doing the
right thing here.

Especially if you create these files on a per isolate basis then you should
close them when shutting down the isolate.


On 2012/06/06 11:06:10, Florian Schneider wrote:

[Florian Schneider, 2012/06/07 09:32:26]

I view this as an experimental flag.

How about abnormal exit (SIGSEGV, SIGTERM, SIGKILL, etc.) then? We rely the
OS/library to clean up in this case.

+}
+
+
 static void ProcessImportMapOption(const char* map) {
   ASSERT(map != NULL);
   import_map_options->AddArgument(map);
 }
 
 
 static struct {
   const char* option_name;
   void (*process)(const char* option);
 } main_options[] = {
   { "--break_at=", ProcessBreakpointOption },
   { "--compile_all", ProcessCompileAllOption },
   { "--debug", ProcessDebugOption },
   { "--generate_pprof_symbols=", ProcessPprofOption },
   { "--import_map=", ProcessImportMapOption },
   { "--package-root=", ProcessPackageRootOption },
+  { "--generate_flow_graph", ProcessFlowGraphOption },
   { NULL, NULL }
 };
 
 
 static bool ProcessMainOptions(const char* option) {
   int i = 0;
   const char* name = main_options[0].option_name;
   while (name != NULL) {
     int length = strlen(name);
     if (strncmp(option, name, length) == 0) {
       main_options[i].process(option + length);
       return true;
     }
     i += 1;
     name = main_options[i].option_name;
   }
   return false;
 }
 
 
+static void WriteToFlowGraphFile(const char* buffer, int64_t num_bytes) {
+  ASSERT(flow_graph_file != NULL);
+  flow_graph_file->WriteFully(buffer, num_bytes);
+}
+
+
 // Parse out the command line arguments. Returns -1 if the arguments
 // are incorrect, 0 otherwise.
 static int ParseArguments(int argc,
                           char** argv,
                           CommandLineOptions* vm_options,
                           char** executable_name,
                           char** script_name,
                           CommandLineOptions* dart_options) {
   const char* kPrefix = "--";
   const intptr_t kPrefixLen = strlen(kPrefix);
@@ skipping 10 matching lines @@
       i++;
     } else {
       vm_options->AddArgument(argv[i]);
       i++;
     }
   }
   if (generate_pprof_symbols_filename != NULL) {
     Dart_InitPprofSupport();
   }
 
+  if (flow_graph_file != NULL) {
+    Dart_InitFlowGraphPrinting(&WriteToFlowGraphFile);
+  }
+
   // Get the script name.
   if (i < argc) {
     *script_name = argv[i];
     i++;
   } else {
     return -1;
   }
 
   // Parse out options to be passed to dart main.
   while (i < argc) {
@@ skipping 550 matching lines @@
   DumpPprofSymbolInfo();
   // Shutdown the isolate.
   Dart_ShutdownIsolate();
   // Terminate process exit-code handler.
   Process::TerminateExitCodeHandler();
 
   free(const_cast<char*>(original_working_directory));
 
   return 0;
 }