Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 10446109: Fixed file leak in test. (Closed)

Created:
8 years, 6 months ago by Sheridan Rawlins
Modified:
8 years, 6 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Fixed file leak in test. R=kinuko@chromium.org, jar@chromium.org BUG=130497 TEST=unit_tests --gtest_filter=FileUtilProxyTest.CreateTemporary Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140006

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M base/file_util_proxy_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sheridan Rawlins
8 years, 6 months ago (2012-05-31 22:29:51 UTC) #1
jar (doing other things)
lgtm
8 years, 6 months ago (2012-06-01 00:35:55 UTC) #2
kinuko
lgtm thanks! On Jun 1, 2012 7:29 AM, <scr@chromium.org> wrote: > Reviewers: kinuko, jar, > ...
8 years, 6 months ago (2012-06-01 03:29:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scr@chromium.org/10446109/1
8 years, 6 months ago (2012-06-01 05:24:41 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-01 09:25:35 UTC) #5
Change committed as 140006

Powered by Google App Engine
This is Rietveld 408576698