Preliminary metro snap plumbing.

First pass at making Chrome support metro snap mode. It creates a fullscreen-alike mode that Chrome may enter when in metro snap mode.

This mode removes the chrome parts of Chrome as well as disabling the F11 key, while clamping Chrome to the size of the snap view portion of the screen.

BUG=130623
TEST=NONE


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141723

[sky, 2012-06-08 16:50:51]

https://chromiumcodereview.appspot.com/10446106/diff/11001/chrome/browser/ui/...
File chrome/browser/ui/browser.cc (right):

https://chromiumcodereview.appspot.com/10446106/diff/11001/chrome/browser/ui/...
chrome/browser/ui/browser.cc:1520: void Browser::ToggleMetroSnapMode(bool
enable) {
This needs to feed into SupportsWindowFeatureImpl. Additionally this should
unify with fullscreen code in BrowserView which shares a lot of similarities.

[robertshield, 2012-06-08 19:12:18]

Thanks, PTAL

http://codereview.chromium.org/10446106/diff/11001/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

http://codereview.chromium.org/10446106/diff/11001/chrome/browser/ui/browser....
chrome/browser/ui/browser.cc:1520: void Browser::ToggleMetroSnapMode(bool
enable) {
On 2012/06/08 16:50:51, sky wrote:
> This needs to feed into SupportsWindowFeatureImpl.

As currently implemented, enabling metro snap implies IsFullscreen() so my
reading of SupportsWindowFeatureImpl suggests that the mode bits set there
should work unchanged.

 Additionally this should
> unify with fullscreen code in BrowserView which shares a lot of similarities.

Yes, definitely, unified.

[sky, 2012-06-11 17:04:31]

What does f11 do when in this mode?

http://codereview.chromium.org/10446106/diff/7002/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

http://codereview.chromium.org/10446106/diff/7002/chrome/browser/ui/browser.c...
chrome/browser/ui/browser.cc:1520: void Browser::ToggleMetroSnapMode(bool
enable) {
Move to browser_win.

http://codereview.chromium.org/10446106/diff/7002/chrome/browser/ui/fullscree...
File chrome/browser/ui/fullscreen_controller.cc (right):

http://codereview.chromium.org/10446106/diff/7002/chrome/browser/ui/fullscree...
chrome/browser/ui/fullscreen_controller.cc:174: void
FullscreenController::ToggleMetroSnapMode(bool enable) {
Since this takes a boolean, it shouldn't be Toggle, but rather Set. This comment
applies to all the places you're adding the function.

http://codereview.chromium.org/10446106/diff/7002/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/browser_view.h (right):

http://codereview.chromium.org/10446106/diff/7002/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_view.h:445: enum ProcessFullscreenType {
How about just FullscreenType

http://codereview.chromium.org/10446106/diff/7002/ui/views/widget/native_widg...
File ui/views/widget/native_widget_win.h (right):

http://codereview.chromium.org/10446106/diff/7002/ui/views/widget/native_widg...
ui/views/widget/native_widget_win.h:539: // Common implementation of
fullscreen-related code.
fullscreen is confusingly named here. Additionally it needs a clear description.

http://codereview.chromium.org/10446106/diff/7002/ui/views/widget/native_widg...
ui/views/widget/native_widget_win.h:625: bool metro_snap_;
Initialize this.

[robertshield, 2012-06-11 21:06:57]

Thanks, PTAL!

Re. the F11 key, it resulted in complete borkage in metro snap mode, much as it
did before this CL. I was going to fix that separately, but since you asked I
added here instead :-)

https://chromiumcodereview.appspot.com/10446106/diff/7002/chrome/browser/ui/b...
File chrome/browser/ui/browser.cc (right):

https://chromiumcodereview.appspot.com/10446106/diff/7002/chrome/browser/ui/b...
chrome/browser/ui/browser.cc:1520: void Browser::ToggleMetroSnapMode(bool
enable) {
On 2012/06/11 17:04:31, sky wrote:
> Move to browser_win.

Done.

https://chromiumcodereview.appspot.com/10446106/diff/7002/chrome/browser/ui/f...
File chrome/browser/ui/fullscreen_controller.cc (right):

https://chromiumcodereview.appspot.com/10446106/diff/7002/chrome/browser/ui/f...
chrome/browser/ui/fullscreen_controller.cc:174: void
FullscreenController::ToggleMetroSnapMode(bool enable) {
On 2012/06/11 17:04:31, sky wrote:
> Since this takes a boolean, it shouldn't be Toggle, but rather Set. This
comment
> applies to all the places you're adding the function.

Done.

https://chromiumcodereview.appspot.com/10446106/diff/7002/chrome/browser/ui/v...
File chrome/browser/ui/views/frame/browser_view.h (right):

https://chromiumcodereview.appspot.com/10446106/diff/7002/chrome/browser/ui/v...
chrome/browser/ui/views/frame/browser_view.h:445: enum ProcessFullscreenType {
On 2012/06/11 17:04:31, sky wrote:
> How about just FullscreenType

Done.

https://chromiumcodereview.appspot.com/10446106/diff/7002/ui/views/widget/nat...
File ui/views/widget/native_widget_win.h (right):

https://chromiumcodereview.appspot.com/10446106/diff/7002/ui/views/widget/nat...
ui/views/widget/native_widget_win.h:539: // Common implementation of
fullscreen-related code.
On 2012/06/11 17:04:31, sky wrote:
> fullscreen is confusingly named here. Additionally it needs a clear
description.

Added more detailed comment. Please let me know if you'd like me to add more.

https://chromiumcodereview.appspot.com/10446106/diff/7002/ui/views/widget/nat...
ui/views/widget/native_widget_win.h:625: bool metro_snap_;
On 2012/06/11 17:04:31, sky wrote:
> Initialize this.

Done.

[sky, 2012-06-11 21:44:01]

LGTM

[commit-bot: I haz the power, 2012-06-12 00:42:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/10446106/12014

[commit-bot: I haz the power, 2012-06-12 00:42:25]

Failed to apply patch for chrome/browser/ui/browser_win.cc:
While running patch -p1 --forward --force;
patching file chrome/browser/ui/browser_win.cc
Hunk #1 FAILED at 9.
1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/ui/browser_win.cc.rej

[commit-bot: I haz the power, 2012-06-12 15:04:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/10446106/18001

[commit-bot: I haz the power, 2012-06-12 15:28:55]

Try job failure for 10446106-18001 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2012-06-12 19:01:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/10446106/11006

[commit-bot: I haz the power, 2012-06-12 20:16:21]

Change committed as 141723