Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 10446103: GestureScrollEnd event had non-zero velocity causing overscroll on software fling path. (Closed)

Created:
8 years, 6 months ago by rjkroege
Modified:
8 years, 6 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews
Visibility:
Public.

Description

GestureScrollEnd event had non-zero velocity causing overscroll on software fling path. GestureScrollEnd (indicating the end of a touchscreen interactive scrolling gesture) contained velocity. This was causing an additional scroll at the start of a touchscreen-initiated fling. BUG=128537 TEST=by hand Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139943

Patch Set 1 #

Patch Set 2 : redundant event removed #

Total comments: 2

Patch Set 3 : added const per review suggestion #

Patch Set 4 : fixed windows build #

Patch Set 5 : fixed unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M ui/aura/gestures/gesture_recognizer_unittest.cc View 1 2 3 4 5 chunks +7 lines, -8 lines 0 comments Download
M ui/base/gestures/gesture_sequence.cc View 1 2 3 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
rjkroege
8 years, 6 months ago (2012-05-31 15:13:50 UTC) #1
sadrul
LGTM https://chromiumcodereview.appspot.com/10446103/diff/2001/ui/base/gestures/gesture_sequence.cc File ui/base/gestures/gesture_sequence.cc (right): https://chromiumcodereview.appspot.com/10446103/diff/2001/ui/base/gestures/gesture_sequence.cc#newcode499 ui/base/gestures/gesture_sequence.cc:499: float velocity_scaling = 1. / 900.; const?
8 years, 6 months ago (2012-05-31 15:19:23 UTC) #2
rjkroege
https://chromiumcodereview.appspot.com/10446103/diff/2001/ui/base/gestures/gesture_sequence.cc File ui/base/gestures/gesture_sequence.cc (right): https://chromiumcodereview.appspot.com/10446103/diff/2001/ui/base/gestures/gesture_sequence.cc#newcode499 ui/base/gestures/gesture_sequence.cc:499: float velocity_scaling = 1. / 900.; On 2012/05/31 15:19:23, ...
8 years, 6 months ago (2012-05-31 15:26:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjkroege@chromium.org/10446103/6002
8 years, 6 months ago (2012-05-31 15:27:05 UTC) #4
commit-bot: I haz the power
Try job failure for 10446103-6002 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 6 months ago (2012-05-31 15:46:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjkroege@chromium.org/10446103/7004
8 years, 6 months ago (2012-05-31 19:24:47 UTC) #6
commit-bot: I haz the power
Presubmit check for 10446103-7004 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-05-31 19:24:53 UTC) #7
rjkroege
+sky for owners in ui/aura/gestures.
8 years, 6 months ago (2012-05-31 19:29:32 UTC) #8
sky
LGTM
8 years, 6 months ago (2012-05-31 20:57:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjkroege@chromium.org/10446103/7004
8 years, 6 months ago (2012-05-31 21:03:08 UTC) #10
commit-bot: I haz the power
8 years, 6 months ago (2012-06-01 01:08:53 UTC) #11
Change committed as 139943

Powered by Google App Engine
This is Rietveld 408576698