Issue 10446093: Upon receiving OnError callback against a context, only clear the set of created contexts if the re…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10446093: Upon receiving OnError callback against a context, only clear the set of created contexts if the re… (Closed)

Created:
8 years, 6 months ago by Ken Russell (switch to Gerrit)

Modified:
8 years, 6 months ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, jochen+watch-content_chromium.org, jamesr, jbauman, piman, nduca

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Upon receiving OnError callback against a context, only clear the set of created contexts if the receiving context is live. Otherwise, it will break sharing among more recently created contexts. BUG=121780, 125246, 125416, 126044 TEST=test cases from above bugs on MacBook Pro with AMD GPU running 10.7.3; more self-contained tests will be created under other bug IDs Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139884

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -1 line)			Patch
	M	content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc	View		4 chunks	+27 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/10446093/1

8 years, 6 months ago (2012-05-31 18:06:16 UTC) #3

Change committed as 139884

Expand Messages | Collapse Messages