Issue 10446092: Disk cache: Don't check the list of entries at startup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10446092: Disk cache: Don't check the list of entries at startup. (Closed)

Created:
8 years, 6 months ago by rvargas (doing something else)

Modified:
8 years, 6 months ago

Reviewers:
gavinp

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Disk cache: Don't check the list of entries at startup. This is intended for the beta channel. BUG=130443 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139886

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	net/disk_cache/backend_impl.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

gavinp

8 years, 6 months ago (2012-05-31 19:49:24 UTC) #2

LGTM.

This makes good sense to me; the check is a really valuable diagnostic in our
early channels, but not appropriate on stable or beta, where we can just fail
later (as we consistency check records as we go through them anyway).

Expand Messages | Collapse Messages