Issue 10446087: Merge 117976 - Chromium AX: Crash when menulist adds selected option via document.write

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10446087: Merge 117976 - Chromium AX: Crash when menulist adds selected option via document.write (Closed)

Created:
8 years, 6 months ago by dmazzoni

Modified:
8 years, 6 months ago

Reviewers:
dmazzoni

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/

Visibility:
Public.

More Reviews

Description

Merge 117976 - Chromium AX: Crash when menulist adds selected option via document.write https://bugs.webkit.org/show_bug.cgi?id=87028 Reviewed by Chris Fleizach. Source/WebCore: Test: platform/chromium/accessibility/add-to-menu-list-crashes.html * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::addChild): LayoutTests: * platform/chromium/accessibility/add-to-menu-list-crashes-expected.txt: Added. * platform/chromium/accessibility/add-to-menu-list-crashes.html: Added. TBR=dmazzoni@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118965

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, --2 lines)			Patch
A +	LayoutTests/platform/chromium/accessibility/add-to-menu-list-crashes.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/platform/chromium/accessibility/add-to-menu-list-crashes-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/WebCore/rendering/RenderMenuList.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages